feat(routing): Add routing infra to contact book manager#99
Merged
mohamedmansour merged 14 commits intomainfrom Mar 13, 2026
Merged
feat(routing): Add routing infra to contact book manager#99mohamedmansour merged 14 commits intomainfrom
mohamedmansour merged 14 commits intomainfrom
Conversation
Handler: - RenderOptions with entry_id and request_path - Route matcher: iterative path matching (no regex) - Route handler: component inventory, f-template queries - Route fragment rendering with specificity-based matching - Perf: escape_html buffer reuse, route scan guard Bindings: - FFI: 6-param webui_handler_render, webui_get_route_templates - Node: render() with entry + requestPath - WASM: routing support in render and build_and_render - CLI serve: JSON partial responses for client navigation Updated DESIGN.md, integration examples, benchmarks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Navigation API interception for SPA transitions - Self-registering <webui-route> custom element via connectedCallback - Iterative path matching with :param, :param?, *splat (no regex) - Specificity-based route ranking - Opt-in lazy loading via loaders config with promise dedup - SSR-safe: preserves server-rendered DOM on initial navigation - Component inventory bloom filter for template dedup - webui:route:navigated CustomEvent after each navigation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xample
- Route definitions in cb-app.html (<route> directive)
- Page components: dashboard, contacts, favorites, group
- Co-located child imports (each component imports its own deps)
- Lazy loading via Router.start({ loaders }) + esbuild --splitting
- Server API for contact CRUD operations
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akroshg
reviewed
Mar 13, 2026
Contributor
There was a problem hiding this comment.
routes made this app so complicated to understand, at least for me.
We should revisit this, once Fast issue gets fixed (specially there are lot of components ts code which I did not bother review it)
Can you also run the performance benchmark before merging code?
cargo bench -p webui --bench contact_book_bench
Contributor
Author
|
mohamedmansour
changed the title
mcritzjam
reviewed
Mar 13, 2026
| totalContacts: contacts.length, | ||
| totalFavorites: favorites.length, | ||
| totalGroups: groups.length, | ||
| groups, |
mcritzjam
reviewed
Mar 13, 2026
| if (query) { | ||
| const q = query.toLowerCase(); | ||
| result = result.filter(c => | ||
| c.firstName.toLowerCase().indexOf(q) !== -1 || |
Contributor
There was a problem hiding this comment.
not saying you have to change it but you have this computeinitials thing as a helper earlier and then you aren't using it here.
mcritzjam
reviewed
Mar 13, 2026
mcritzjam
reviewed
Mar 13, 2026
mcritzjam
reviewed
Mar 13, 2026
mohamedmansour
commented
Mar 13, 2026
Contributor
Author
mohamedmansour
left a comment
mohamedmansour
left a comment
There was a problem hiding this comment.
First pass
janechu
reviewed
Mar 13, 2026
| phone: c.getAttribute('phone') || '', | ||
| company: c.getAttribute('company') || '', | ||
| group: c.getAttribute('group') || '', | ||
| favorite: c.getAttribute('favorite') === 'true', |
Contributor
There was a problem hiding this comment.
Isn't this a boolean? I think I would expect c.hasAttribute('favorite')
janechu
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactors the contact-book-manager example from a single-page monolith into a route-based architecture with lazy-loaded page components and a dedicated Express API server.
Changes
text-decoration