Conversation
nigriMSFT
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for:
The miniport can indicate and receive the offloads on the data path via OOBs independent of the configured state, which allows probing of race conditions and, in the case of RSC and URO, mild NIC misbehavior.
The control path allows rich configurability to extensively probe the control path: both the current and hardware capabilities are configurable via the registry prior to the miniport loading, and at runtime, the registry values can be dynamically reloaded, and the offload parameters OID can be sent directly to the driver to override the registry values. The NIC does not enforce any relationship between hardware capabilities and active configuration, which again allows contradictory behavior, but these misbehaviors should be handled appropriately by the components under test.
Only the UDPv4 checksum is covered in functional tests within this repo; the rest are presumed to be tested by other projects implicitly.