Conversation
nibanks
reviewed
Jun 14, 2024
| _IRQL_requires_same_ | ||
| _IRQL_requires_(PASSIVE_LEVEL) | ||
| NTSTATUS | ||
| DriverEntry( |
Contributor
There was a problem hiding this comment.
Since you don't have a driver service, I think the DriverEntry isn't necessary, but since it doesn't hurt we can leave it.
Contributor
Author
There was a problem hiding this comment.
It is unused (not called), but the driver framework seems to expect it
2>WdfDriverEntry.lib(stub.obj) : error LNK2019: unresolved external symbol DriverEntry referenced in function FxDr
iverEntryWorker [N:\repos\win-net-test\src\sock\km\fnsock_km.vcxproj]
2>N:\repos\win-net-test\artifacts\bin\amd64chk\fnsock_km.sys : fatal error LNK1120: 1 unresolved externals [N:\rep
os\win-net-test\src\sock\km\fnsock_km.vcxproj]
nibanks
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose FnSock as dll/sys libraries. This makes consumption more flexible compared to static libs (which brings in complexities such as libs compiled with different CRTs). The next step will be to package the headers and import libs into a nuget package that other projects can consume.