v46 has name collision

[kennykerr]

MENU_POPUPSUBMENU_HCHOT is defined as both a constant and a struct in the same namespace.

The new vsstyle.h is really problematic - this was not updated with programming languages in mind. 😶

Not sure what to do about it. C and C++ floods the enclosing scope with any enumerators for unscoped enumerations but vsstyle.h defines MENU_POPUPSUBMENU_HCHOT as both a type and as an enumerator (constant).

MSVC seems to accommodate this as contextual, but Rust doesn't like this.

[kennykerr]

Given the header:

enum SYSTEMMINIMIZESTATES {
	MSYSMN_NORMAL = 1,
	MSYSMN_DISABLED = 2,
};

enum SYSTEMRESTORESTATES {
	MSYSR_NORMAL = 1,
	MSYSR_DISABLED = 2,
};

enum MENU_POPUPSUBMENU_HCHOT {
	MSMHC_HOT = 1,
};

enum SYSTEMCLOSEHCHOTSTATES {
	MSYSCHC_HOT = 1,
};

enum SYSTEMMAXIMIZEHCHOTSTATES {
	MSYSMXHC_HOT = 1,
};

It looks very much like the MENU_POPUPSUBMENU_HCHOT enum was mistakenly named the same as a constant - basically a typo. I just wonder what it was meant to be called. Perhaps we can fix it.

[kennykerr]

Looked it up in the OS repo. It's meant to be:

enum POPUPSUBMENUHCHOTSTATES {
	MSMHC_HOT = 1,
};

Mike, can we fix that here until a new SDK arrives?