Fix method counting for interfaces when scanning references#1427
Merged
mikebattista merged 1 commit intomicrosoft:mainfrom Jan 13, 2023
Merged
Fix method counting for interfaces when scanning references#1427mikebattista merged 1 commit intomicrosoft:mainfrom
mikebattista merged 1 commit intomicrosoft:mainfrom
Conversation
Member
|
Change looks great, thanks for including new test collateral, and for tackling this issue! |
BenJKuhn
approved these changes
Jan 13, 2023
mikebattista
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClangSharpSourceWinmdGeneratormaintains a cache of encountered interface types and their method counts. This information is currently obtained during two phases:The input syntax trees (1) contain interface types with all inherited and local methods already emitted. When
ClangSharpSourceWinmdGeneratorperforms aMethodDeclarationSyntaxcount, it caches the correct value.Example input fragment:
The compilation references (2) (e.g. Windows.Win32.winmd) however contain interface types that do not have these methods emitted.
ClangSharpSourceWinmdGeneratorinstead counts the number of methods on the type specified byNativeInheritanceand moves on, resulting in an inaccurate count. This count is used later to skip over inherited methods when emitting interface method metadata, resulting in interfaces with invalid method members.Example output metadata:
This impacts all projects with references to Windows.Win32.winmd and the Microsoft.Windows.WinmdGenerator. (Generally everyone outside of win32metadata.)
This PR fixes method counting during the compilation reference walk by also counting the methods for each interface implemented by an interface type. This information is obtained via the
InterfaceImpltable (II.22.23).Fixes: #1426