Added MidlSwitches for #1428.

[mikebattista]

I followed the existing pattern for AdditionalIncludes to add MidlSwitches for #1428.

[mikebattista]

@benkuhn if we wanted to set /notlb as the default, I believe we would make that change in commonMidlArgs.

[abolade]

This looks fine for simply appending switches to the midl.exe command line.

If the command line needs to be replaced, a different approach might be needed: check if MidlSwitches is null or empty and, if so, use the defaults currently set in commonMidlArgs; otherwise, use the contents of MidlSwitches instead of the defaults currently set in commonMidlArgs.

[mikebattista]

Thanks. For now, I'd like to start with being able to append flags that are missing.

Unless we want to make a change to set /notld by default per @benkuhn's comments, then we can set that switch in the default arguments.

Are there other MIDL parameters that would need to be appended in this way besides /notld? If we made /notld the default, would we still want to have this ability to append additional arguments?

[riverar]

I'd just hardcode /notld and not allow for the configurability. Otherwise it may give others the impression they can pass in other parameters (that may break win32metadata).

But am okay with the changes as they stand right now.

[mikebattista]

If we want to keep this, I believe the below would also need to be updated to pass through the user-defined switches to the CompileIdls Task.

win32metadata/sources/GeneratorSdk/sdk/sdk.targets

Lines 124 to 133 in e6e1456

	<CompileIdls
	Idls="@(Idls)"
	ObjDir="$(ObjDir)"
	CompiledHeadersDir="$(CompiledHeadersDir)"
	ScriptsDir="$(ScriptsDir)"
	SdkIncRoot="$(SdkIncRoot)"
	SdkBinDir="$(WindowsSDKVersionedBinRoot)"
	AdditionalIncludes="$(AdditionalIncludes)"
	MSBuildProjectDirectory="$(MSBuildProjectDirectory)"/>
	</Target>

[mikebattista]

What are the implications of setting /notlb by default? Is that expected to work in all scenarios?

[kennykerr]

That should be safe. Since you aren't consuming tlb files, you can safely avoid generating them.

[mikebattista]

Ok. I will set it by default and leave the custom additional flags support in. It's optional so there's no harm in leaving it there as an experiment.