Skip to content

Conversation

@mikebattista
Copy link
Contributor

More namespace refactoring.

Need help resolving the below duplicate constants errors before merging.

Duplicate constants/enum names detected:
GUID_DEVINTERFACE_USBPRINT
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
GUID_DEVINTERFACE_IPPUSB_PRINT
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
NOTIFICATION_RELEASE
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
PRINT_APP_BIDI_NOTIFY_CHANNEL
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis
PRINT_PORT_MONITOR_NOTIFY_CHANNEL
Windows.Win32.Graphics.Printing.Apis
Windows.Win32.Graphics.Printing.Apis

@mikebattista mikebattista requested a review from sotteson1 May 16, 2021 08:00
@mikebattista
Copy link
Contributor Author

@sotteson1 the CI build is failing saying the below were removed from the baseline, but I can't reproduce with a clean build locally. Local builds work fine with no differences. The baseline winmds on my machine from master and my branch don't have these APIs, and I can't find them defined anywhere in the SDK. In fact, we have another PR to add most of these manually, so it's not clear why the baseline used in the CI build has them.

Comparing E:\BA\31\s\bin\Windows.Win32.winmd against baseline E:\BA\31\s\scripts\BaselineWinmd\Windows.Win32.winmd...
Calling: dotnet E:\BA\31\s\bin\release\netcoreapp3.1\WinmdUtils.dll compare --first E:\BA\31\s\scripts\BaselineWinmd\Windows.Win32.winmd --second E:\BA\31\s\bin\Windows.Win32.winmd
Windows.Win32.Graphics.Hlsl.Apis.DXC_CP_UTF8 not found in 2nd winmd
Windows.Win32.Graphics.Hlsl.Apis.DXC_CP_UTF16 not found in 2nd winmd
Windows.Win32.Graphics.Hlsl.Apis.DXC_CP_ACP not found in 2nd winmd
Windows.Win32.Graphics.Hlsl.Apis.DXC_HASHFLAG_INCLUDES_SOURCE not found in 2nd winmd

@MarijnS95
Copy link
Contributor

MarijnS95 commented May 18, 2021

@mikebattista the same came up in #450 (comment), those constants/preprocessor-defines do not exist in the current SDK.

Note that the last master commit failed. I cannot see the logs, but possibly @sotteson1 regenerated with a newer SDK in 24056ce (showing a similar size decrease as the comment linked above) making those constants reappear, clarifying the failure and the reason you see these errors in this PR too.

@mikebattista
Copy link
Contributor Author

Thanks. I just noticed master was failing as well as of 24056ce which I just merged into this branch.

The launchsettings.json changes look suspicious. There might be a bug there.

@sotteson1
Copy link
Contributor

Thanks. I just noticed master was failing as well as of 24056ce which I just merged into this branch.

The launchsettings.json changes look suspicious. There might be a bug there.

That file is only used when debugging in VS.

@mikebattista
Copy link
Contributor Author

@mikebattista the same came up in #450 (comment), those constants/preprocessor-defines do not exist in the current SDK.

Note that the last master commit failed. I cannot see the logs, but possibly @sotteson1 regenerated with a newer SDK in 24056ce (showing a similar size decrease as the comment linked above) making those constants reappear, clarifying the failure and the reason you see these errors in this PR too.

@MarijnS95 you might be right here but it might be a bug that the constant scraper is pulling things in from newer SDKs installed on the local machine, rather than the SDK that is expected to be used from the repo. Steve is looking into it.

@mikebattista mikebattista merged commit cc74484 into master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants