Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the npm package from JavaScript to TypeScript, adding comprehensive type safety and modern development tooling. The migration involves converting all JavaScript modules to TypeScript, setting up TypeScript compilation, and adding ESLint and Prettier for code quality.
Changes:
- Converted all JavaScript source files to TypeScript with proper type annotations
- Added TypeScript configuration with strict type checking enabled
- Integrated ESLint with TypeScript plugin and Prettier for code formatting
- Updated package.json with new build pipeline and tooling scripts
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | TypeScript compiler configuration with strict mode and source maps |
| src/winapp-cli-utils.ts | Converted CLI utilities with typed interfaces for options and results |
| src/msix-utils.ts | Converted MSIX utilities with proper type definitions |
| src/utils.ts | Converted project root utility with type safety |
| src/winapp-path-utils.ts | Converted path utilities with typed functions |
| src/dependency-utils.ts | Converted dependency installation utilities with typed functions |
| src/cpp-addon-utils.ts | Converted C++ addon generator with typed options and results |
| src/cs-addon-utils.ts | Converted C# addon generator with typed options and results |
| src/cli.ts | Converted CLI entry point with typed argument parsing |
| src/buildtools-utils.ts | Converted build tools utilities with proper type annotations |
| src/index.ts | New typed main entry point with proper exports |
| package.json | Updated with TypeScript dependencies and new build scripts |
| eslint.config.mjs | ESLint configuration for TypeScript with recommended rules |
| .prettierrc | Prettier formatting configuration |
| scripts/package-npm.ps1 | Updated packaging script to compile TypeScript |
Files not reviewed (1)
- src/winapp-npm/package-lock.json: Language not supported
Comments suppressed due to low confidence (4)
src/winapp-npm/src/cpp-addon-utils.ts:112
- The template directory path needs to be adjusted for the TypeScript compilation structure. Since TypeScript files are compiled from
src/todist/, the template directory should be../addon-template(going up fromdist/to the package root), not./addon-template.
src/winapp-npm/src/cs-addon-utils.ts:200 - The template directory path needs to be adjusted for the TypeScript compilation structure. Since TypeScript files are compiled from
src/todist/, the template directory should be../cs-addon-template(going up fromdist/to the package root), not./cs-addon-template.
src/winapp-npm/src/cli.ts:85 - The package.json path resolution uses
require.resolve('../package.json')which may not work correctly with the new TypeScript compilation structure. When the code is compiled todist/, the relative path should still be../package.jsonto reach the root package.json, but this might fail if Node's module resolution doesn't find it. Consider using a more explicit path likepath.join(__dirname, '../package.json')or verify this works in the compiled output.
src/winapp-npm/src/cs-addon-utils.ts:297 - This use of variable 'verbose' always evaluates to false.
Collaborator
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
nmetulev
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #240 and #239