Add Assets to resources.pri + Support Qualified Names in Appxmanifest#320
Merged
Add Assets to resources.pri + Support Qualified Names in Appxmanifest#320
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances MSIX packaging by properly including all asset variants in the resources.pri file and fixing asset discovery when qualified MRT names (e.g., "Logo.scale-100.png") are specified in the manifest. This enables proper display of unplated icons in the Windows taskbar and ensures all scaled/themed variants are bundled even when the manifest references a specific qualified asset.
Changes:
- Modified PRI generation to enumerate and index all image assets in the Assets folder instead of just .pri files
- Added support for parsing qualified MRT asset names to extract the base name (e.g., "Logo.scale-100" → "Logo")
- Updated asset file discovery to find all variants of a given asset family regardless of which specific qualified name is referenced in the manifest
Build Metrics ReportBinary Sizes
Test Results✅ 299 passed, 6 skipped out of 305 tests in 54.4s (+5 tests, +9.1s vs. baseline) CLI Startup Time31ms median (x64, Updated 2026-02-27 19:22:56 UTC · commit |
nmetulev
reviewed
Feb 25, 2026
nmetulev
reviewed
Feb 27, 2026
nmetulev
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #298
Description
Usage Example
No commands change.
Type of Change
Checklist
Screenshots / Demo
PRI XAML Example:
Before this change the pri XAML was very simply. Its main entry was just
<ResourceMap name="electron-gallery" version="1.0" primary="true">.Additional Notes
AI Description
This pull request enhances the resource management in the WinApp CLI by adding support for including various asset types in the resources.pri file, enabling unplated assets to appear correctly in the Taskbar. Additionally, it refactors asset handling in the appxmanifest to ensure that scaled assets are included in the packaging process when specified. The XML parsing approach has also been improved for better reliability.