improving how ico files are created during update-assets#360
Merged
Conversation
Build Metrics ReportBinary Sizes
Test Results✅ 414 passed out of 414 tests in 379.1s (+7 tests, +24.6s vs. baseline) Test Coverage❌ 42.3% line coverage, 46.1% branch coverage · ✅ no change vs. baseline CLI Startup Time36ms median (x64, Updated 2026-03-26 05:46:03 UTC · commit |
chiaramooney
approved these changes
Mar 26, 2026
Contributor
chiaramooney
left a comment
chiaramooney
left a comment
There was a problem hiding this comment.
Looks good; do we have a test which validates this behavior already?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update-assets now checks for existing ico files to replace