Skip to content

Bump electron from 37.1.0 to 37.3.1 in /sample#4

Merged
azchohfi merged 1 commit into
mainfrom
dependabot/npm_and_yarn/sample/electron-37.3.1
Sep 4, 2025
Merged

Bump electron from 37.1.0 to 37.3.1 in /sample#4
azchohfi merged 1 commit into
mainfrom
dependabot/npm_and_yarn/sample/electron-37.3.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Sep 4, 2025

Bumps electron from 37.1.0 to 37.3.1.

Release notes

Sourced from electron's releases.

electron v37.3.1

Release Notes for v37.3.1

Fixes

  • Fixed an issue where shell.openPath was not non-blocking as expected. #48088 (Also in 36, 38)
  • Fixed an issue where windows opened with window.open would never be offscreen. #48070 (Also in 38)
  • Fixed potential deadlock inside app.getLoginItemSettings on macOS. #48096 (Also in 36)

Other Changes

  • Updated Chromium to 138.0.7204.235. #48066

electron v37.3.0

Release Notes for v37.3.0

Features

  • Added support for app.getRecentDocuments() on Windows and macOS. #47923 (Also in 36, 38)
  • Adds the ability to change window accent color on Windows after initial window initialization via {get|set}AccentColor. #48017 (Also in 36, 38)
  • Internally switched to using DIR_ASSETS instead of DIR_MODULE/DIR_EXE to locate assets and resources, and added "assets" as a key that can be queried via app.getPath. #47951 (Also in 38)

Fixes

  • Fixed a crash possible when calling webContents.loadURL() from a failed webContents.loadURL() call's catch handler. #48045 (Also in 36, 38)
  • Fixed an issue where app.accessibilitySupportEnabled didn't work as expected. #48061 (Also in 38)
  • Fixed an issue where importing from electron/utility in an ESM file threw an error at runtime. #48021 (Also in 36, 38)
  • Fixed an issue where importing from electron/utility threw a ERR_MODULE_NOT_FOUND error at runtime. #47988 (Also in 36, 38)
  • Fixed an issue where the accent border was drawn on all windows regardless of the window's active focused status. #48011 (Also in 36, 38)
  • Fixed compilation error when disabling extensions and pdf_viewer. #47994 (Also in 38)

Other Changes

  • Updated Chromium to 138.0.7204.224. #47974
  • Updated Node.js to v22.18.0. #47935

electron v37.2.6

Release Notes for v37.2.6

Fixes

  • Fixed a bug where the Referer header was not being set correctly when using webContents.downloadURL(). #47865 (Also in 36, 38)
  • Fixed a crash when calling some webContents functions after window.close(). #47954 (Also in 36, 38)
  • Fixed an issue on some older Windows versions where setContentProtection didn't work as expected. #47887 (Also in 36, 38)
  • Fixed an issue where an invalid color passed as a string to accentColor would result in a white accent color. #47800 (Also in 38)
  • Fixed an issue where video scrubbing would not correctly hold the new position on playback. #47971 (Also in 38)
  • Fixed an issue where windows used dark theme on Linux all the time without reacting to system theme changes. #47920 (Also in 38)
  • Fixed applying background material correctly when creating windows on Windows, restored animations, and also fixed the issue where dynamically setting the background material had no effect. #47956 (Also in 36, 38)

Other Changes

  • Updated Chromium to 138.0.7204.185. #47909

electron v37.2.5

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [electron](https://github.com/electron/electron) from 37.1.0 to 37.3.1.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v37.1.0...v37.3.1)

---
updated-dependencies:
- dependency-name: electron
  dependency-version: 37.3.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 4, 2025
@azchohfi azchohfi merged commit 71f575b into main Sep 4, 2025
1 check passed
@azchohfi azchohfi deleted the dependabot/npm_and_yarn/sample/electron-37.3.1 branch September 4, 2025 21:55
nmetulev added a commit that referenced this pull request Apr 30, 2026
Code review fixes:

- Tighten gate (Copilot #1, L1): Drop the standalone WindowsPackageType=='MSIX'
  activation clause and capture _WinAppManifestPathUserSet *before* the manifest
  auto-detection runs. The gate now only counts an explicitly user-set
  WinAppManifestPath, never an auto-detected output-dir path. This eliminates
  a class of subtle false-positives where a stale bin/AppxManifest.xml from a
  prior build would activate the gate on rebuild.

- WinAppRunSupportInfo (L2): Print TargetPlatformIdentifier (raw),
  _WinAppEffectiveTargetPlatformIdentifier (used by gate), and
  _WinAppManifestPathUserSet so diagnostics mirror the actual gate inputs.

- Doc/gate semantics alignment (Copilot #5): docs/dotnet-run-support.md now
  says "EnableWinAppRunSupport is true (the default)" instead of "is not set
  to false", matching the actual gate condition (== 'true').

Tests (Copilot #3, #4, M4):

- Skip on non-Windows hosts via $IsWindows.
- Add Get-GateValue parameters: -ProjectDirManifestName (named manifest
  filename), -TargetPlatformIdentifier (explicit TPI override).
- Add new cases: project-dir Package.appxmanifest, project-dir
  AppxManifest.xml, explicit TargetPlatformIdentifier=windows on a non-windows
  TFM, explicit TargetPlatformIdentifier=android overriding a windows TFM.
- Add regression case: WindowsPackageType=MSIX with no manifest must be
  inactive (replaces the previous active case).
- Suite is now 18 tests, all passing.

CI integration (M3):

- scripts/build-cli.ps1 now invokes Invoke-Pester against
  src/winapp-NuGet/tests/NuGet.Tests.ps1 immediately after package-nuget.ps1
  succeeds (skipped if -SkipTests is passed). Honors $FailOnTestFailure.

Docs (M1, L3, M2):

- README: replace stale Version="0.1.10" pins with <latest> placeholder
  + link to nuget.org.
- README: new "Behavior changes" section explaining the
  DevelopmentDependency removal so direct consumers know to add
  PrivateAssets="all" if they don't want the package to flow into their
  own .nupkg output.
- README: new troubleshooting entry "dotnet run is not intercepted" pointing
  users at `dotnet msbuild -t:WinAppRunSupportInfo` and listing the five
  gate discriminators.

CI failures on PR #513 (build-and-package, electron) were pre-existing on
main (E2E_DotNetApp_PackageShouldIncludeRuntimeDependency) or flaky/unrelated
(electron C# native addon build) and are not caused by this PR. The four
.NET-using sample jobs (dotnet-app, wpf-app, cpp-app, packaging-cli) all pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant