feat: Add crash dump capture and analysis to --debug-output#414
Merged
feat: Add crash dump capture and analysis to --debug-output#414
Conversation
Build Metrics ReportBinary Sizes
Test Results✅ 718 passed out of 718 tests in 368.7s (+4 tests, -6.3s vs. baseline) Test Coverage❌ 20.6% line coverage, 35.8% branch coverage · CLI Startup Time39ms median (x64, Updated 2026-04-10 00:02:10 UTC · commit |
lei9444
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 35 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 39 out of 60 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
src/winapp-CLI/WinApp.Cli/Commands/RunCommand.cs:136
- --symbols is described as “only used with --debug-output”, but there’s no validation preventing users from passing --symbols without --debug-output (it will be silently ignored). Add an explicit check (useSymbols && !debugOutput) to return an error, or hide the option unless --debug-output is set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…g noise - Add PdbSourceResolver to CrashDumpService that reads portable PDBs using System.Reflection.Metadata to map ClrMD stack frames to source file:line - Thread symbolSearchPaths (build output folder) through IDebugOutputService and ICrashDumpService interfaces so PDBs are found without copying - Apply source resolution to exception stacks, stack overflow detection, and all-threads detail log - Filter OutputDebugString console output to suppress OS/framework noise (WinUI, COM, DirectX, kernel traces) while logging everything to file - Filter first-chance exceptions on console to only show CLR, AV, and SOE while logging all exception codes to the debug log file Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… resolution - Show tip to re-run with --symbols when a native crash occurs without it - Update debugging.md and usage.md to document source file:line resolution from PDBs and console noise filtering behavior - Add --symbols usage example to usage.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…HANDLE for dump capture - Thread useSymbols parameter into LaunchViaExecutionAliasAsync so --symbols is not silently ignored when combined with --with-alias - Add PROCESS_DUP_HANDLE access right to OpenProcess call in WriteMiniDump, required by MiniDumpWithHandleData dump type Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…f stack trace When winapp (ARM64) debugs an x64 app under emulation, ClrMD cannot load the cross-architecture DAC DLL. Detect the architecture mismatch early and display a clean message pointing the user to WinDbg, instead of dumping an internal ClrDiagnosticsException stack trace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Display debug log path when app exits normally (no crash), so users can find captured OutputDebugString messages and first-chance exceptions - Remove unused threadId parameter from WriteMiniDump — it was accepted but never used, misleading callers about its purpose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nmetulev
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a WinUI 3 app crashes during winapp run --debug-output, the previous output only showed a bare exception code and address. This PR adds automatic crash dump capture and in-process analysis using ClrMD (Microsoft.Diagnostics.Runtime) — no external tools required.
How it works
Flow:
App crashes → Write dump → ClrMD analysis → Found managed exception?
→ Yes: Show exception type, message, managed stack trace
→ No: Fall back to DbgEng native analysis (with or without symbols)
→ Terminal shows summary, full details in log file
Output layering
Terminal: Crash summary: faulting symbol, module, source file:line, compact stack (framework frames collapsed)
Log file: All OutputDebugString messages, first-chance exceptions, full thread stacks with module names
Dump file: Full memory minidump for deep analysis with WinDbg or Visual Studio
Usage Example
Related Issue
Type of Change
Checklist
Screenshots / Demo
AI Description
This PR introduces crash dump capture and automated analysis during app execution with the
--debug-outputflag. When a WinUI 3 app crashes, the tool now automatically writes a minidump and performs a managed or native analysis without needing external tools. Users can enrich native crash analysis by adding the--symbolsflag to download PDBs for better diagnostics.Usage example:
Breaking Change: None.