Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ort' into alzollin/dotnetSupport
Refactored the code to collect all <dependency> nodes from the .nuspec XML, removing the previous logic that distinguished between ungrouped and grouped dependencies. This streamlines dependency extraction but may mix dependencies from different target frameworks.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ort' into alzollin/dotnetSupport
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix getWinappCliPath: only check on-disk paths with fs.existsSync, fall back to bare 'winapp' for system PATH resolution - Fix runWinappCommand: explicitly set shellPath to powershell.exe so the & call operator works regardless of user's default terminal shell - Fix watch task: add esbuild background problem matcher so preLaunchTask doesn't hang waiting for task readiness - Fix package-nuget.ps1: add missing -SkipTemplates switch parameter declaration so the flag actually works Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 45 out of 55 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .vscode/** | ||
| .vscode-test/** | ||
| src/** | ||
| !bin/**/*.exe | ||
| out/** | ||
| node_modules/** |
There was a problem hiding this comment.
.vscodeignore currently doesn't exclude bin/**, so all files under bin/ will be packaged into the VSIX. The !bin/**/*.exe negation has no effect unless bin/** is excluded first. Consider excluding bin/** and then re-including only the required CLI artifacts (e.g., !bin/**/*.exe, and any other required files), to avoid accidentally shipping large publish outputs.
| out/** | ||
| node_modules/** | ||
| .gitignore |
There was a problem hiding this comment.
package-lock.json is not excluded, so it will be included in the published VSIX even though it isn't needed at runtime. Add it to .vscodeignore to reduce package size.
….targets Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot apply changes based on the comments in this thread |
…ts, and doc accuracy Agent-Logs-Url: https://github.com/microsoft/winappCli/sessions/9fe3750e-01e6-480b-9f3e-c10a15511d74 Co-authored-by: chiaramooney <34109996+chiaramooney@users.noreply.github.com>
Applied all changes from that review thread in commit 5ee1c99:
|
Description
Merge VS Code extension into main. Includes Winapp commands, launch and debug, and README. Does not include extension in publish.
Adds WinUI templates.
Usage Example
Install extension in VS Code and use commands/launch windows apps.
Related Issue
Type of Change
Checklist
Screenshots / Demo
Additional Notes
AI Description
This pull request merges the VS Code extension into the main codebase, introducing Winapp commands, launch, and debug features. Additionally, it adds WinUI templates and includes updated documentation reflecting these changes. Users can now install the extension and utilize commands for launching Windows apps directly from VS Code.