Skip to content

Merge VS Code Extension into main#420

Merged
nmetulev merged 157 commits intomainfrom
alzollin/vsc
Apr 17, 2026
Merged

Merge VS Code Extension into main#420
nmetulev merged 157 commits intomainfrom
alzollin/vsc

Conversation

@chiaramooney
Copy link
Copy Markdown
Contributor

@chiaramooney chiaramooney commented Apr 9, 2026

Description

Merge VS Code extension into main. Includes Winapp commands, launch and debug, and README. Does not include extension in publish.

Adds WinUI templates.

Usage Example

Install extension in VS Code and use commands/launch windows apps.

Related Issue

Type of Change

  • ✨ New feature

Checklist

  • New tests added for new functionality (if applicable)
  • Tested locally on Windows
  • Main README.md updated (if applicable)
  • docs/usage.md updated (if CLI commands changed)

Screenshots / Demo

Additional Notes

AI Description

This pull request merges the VS Code extension into the main codebase, introducing Winapp commands, launch, and debug features. Additionally, it adds WinUI templates and includes updated documentation reflecting these changes. Users can now install the extension and utilize commands for launching Windows apps directly from VS Code.

# Add alias inferred from the Executable attribute in the manifest
winapp manifest add-alias

# Specify the alias name explicitly
winapp manifest add-alias --name myapp

# Target a specific manifest file
winapp manifest add-alias --manifest ./path/to/appxmanifest.xml

azchohfi and others added 30 commits February 11, 2026 12:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Refactored the code to collect all <dependency> nodes from the .nuspec XML, removing the previous logic that distinguished between ungrouped and grouped dependencies. This streamlines dependency extraction but may mix dependencies from different target frameworks.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
chiaramooney and others added 11 commits April 10, 2026 11:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Fix getWinappCliPath: only check on-disk paths with fs.existsSync,
  fall back to bare 'winapp' for system PATH resolution
- Fix runWinappCommand: explicitly set shellPath to powershell.exe so
  the & call operator works regardless of user's default terminal shell
- Fix watch task: add esbuild background problem matcher so
  preLaunchTask doesn't hang waiting for task readiness
- Fix package-nuget.ps1: add missing -SkipTemplates switch parameter
  declaration so the flag actually works

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 45 out of 55 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/winapp-NuGet/build/Microsoft.Windows.SDK.BuildTools.WinApp.targets Outdated
Comment on lines +1 to +6
.vscode/**
.vscode-test/**
src/**
!bin/**/*.exe
out/**
node_modules/**
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscodeignore currently doesn't exclude bin/**, so all files under bin/ will be packaged into the VSIX. The !bin/**/*.exe negation has no effect unless bin/** is excluded first. Consider excluding bin/** and then re-including only the required CLI artifacts (e.g., !bin/**/*.exe, and any other required files), to avoid accidentally shipping large publish outputs.

Copilot uses AI. Check for mistakes.
Comment on lines +5 to +7
out/**
node_modules/**
.gitignore
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json is not excluded, so it will be included in the published VSIX even though it isn't needed at runtime. Add it to .vscodeignore to reduce package size.

Copilot uses AI. Check for mistakes.
Comment thread src/winapp-VSC/tsconfig.json
Comment thread src/winapp-VSC/package.json
Comment thread src/winapp-VSC/README.md
Comment thread docs/getting-started.md Outdated
….targets

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chiaramooney
Copy link
Copy Markdown
Contributor Author

@copilot apply changes based on the comments in this thread

…ts, and doc accuracy

Agent-Logs-Url: https://github.com/microsoft/winappCli/sessions/9fe3750e-01e6-480b-9f3e-c10a15511d74

Co-authored-by: chiaramooney <34109996+chiaramooney@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

@copilot apply changes based on the comments in this thread

Applied all changes from that review thread in commit 5ee1c99:

  • .vscodeignore: Added bin/** before !bin/**/*.exe so the negation works correctly, and added package-lock.json to reduce VSIX size
  • tsconfig.json: Removed DOM from lib to avoid masking browser-only globals in the Node extension host
  • package.json: Changed activationEvents from onDebug to onDebugResolve:winapp so the extension only activates for WinApp debug sessions
  • README.md: Updated "How it works" step 2 to accurately describe that the extension scans for .exe files and uses manifest from launch.json or CLI auto-detection
  • docs/getting-started.md: Updated the winapp run description to say it takes a build output folder (with optional --manifest), not a path to AppxManifest.xml

Comment thread docs/getting-started.md Outdated
@chiaramooney chiaramooney requested a review from nmetulev April 16, 2026 18:45
@nmetulev nmetulev merged commit e8d9a52 into main Apr 17, 2026
12 checks passed
@nmetulev nmetulev deleted the alzollin/vsc branch April 17, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants