Skip to content

fix(nuget): add compliant Copyright element for Microsoft NuGet policy#489

Merged
nmetulev merged 1 commit into
mainfrom
fix/nuget-copyright
Apr 22, 2026
Merged

fix(nuget): add compliant Copyright element for Microsoft NuGet policy#489
nmetulev merged 1 commit into
mainfrom
fix/nuget-copyright

Conversation

@nmetulev
Copy link
Copy Markdown
Member

Adds the required <Copyright> element to Microsoft.Windows.SDK.BuildTools.WinApp.csproj so the NuGet package satisfies Microsoft's nuget.org compliance policy (https://aka.ms/Microsoft-NuGet-Compliance). Without this element, nuget push fails with HTTP 400: The package metadata contains a non-compliant copyright element.

Sets:

<Copyright>(c) Microsoft Corporation. All rights reserved.</Copyright>

(uses the © character in the actual file — exact string required by policy).

This was already cherry-picked to rel/v0.3.0 as f3db417 so the in-flight 0.3.0 NuGet republish can succeed. Merging here ensures future releases ship compliant metadata by default.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

NuGet.org rejects Microsoft packages whose copyright element is empty or
does not match the required string. Add the canonical value:

    Copyright = '© Microsoft Corporation. All rights reserved.'

Verified against the generated .nuspec via 'dotnet pack'.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 22, 2026 06:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds NuGet package metadata needed for publishing Microsoft.Windows.SDK.BuildTools.WinApp to comply with Microsoft’s nuget.org policy requirements.

Changes:

  • Add a compliant <Copyright> element to the NuGet package .csproj.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

Build Metrics Report

Binary Sizes

Artifact Baseline Current Delta
CLI (ARM64) 30.66 MB 30.66 MB ✅ 0.0 KB (0.00%)
CLI (x64) 31.02 MB 31.02 MB ✅ 0.0 KB (0.00%)
MSIX (ARM64) 12.94 MB 12.94 MB 📈 +0.1 KB (+0.00%)
MSIX (x64) 13.74 MB 13.74 MB 📉 -0.0 KB (-0.00%)
NPM Package 26.90 MB 26.90 MB 📉 -0.3 KB (-0.00%)
NuGet Package 26.98 MB 26.98 MB 📈 +0.2 KB (+0.00%)
VS Code Extension 19.72 MB 19.72 MB 📈 +0.4 KB (+0.00%)

Test Results

783 passed, 1 skipped out of 784 tests in 452.7s (+35.0s vs. baseline)

Test Coverage

21.5% line coverage, 36.6% branch coverage · ✅ no change vs. baseline

CLI Startup Time

41ms median (x64, winapp --version) · ✅ no change vs. baseline


Updated 2026-04-22 06:56:09 UTC · commit b6c5887 · workflow run

@nmetulev nmetulev merged commit 734bd04 into main Apr 22, 2026
25 checks passed
@nmetulev nmetulev deleted the fix/nuget-copyright branch April 22, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants