Adds support for port forwarding on non-nat network types#35
Merged
nagiesek merged 2 commits intomicrosoft:masterfrom May 8, 2019
Merged
Adds support for port forwarding on non-nat network types#35nagiesek merged 2 commits intomicrosoft:masterfrom
nagiesek merged 2 commits intomicrosoft:masterfrom
Conversation
|
|
nagiesek
reviewed
May 8, 2019
Contributor
nagiesek
left a comment
nagiesek
left a comment
There was a problem hiding this comment.
No complaints. Passed tests ok, so all I'd like is the acl portion to be placed into a seperate function, but I'm not hard on that.
| } | ||
| logrus.Debugf("Created raw policy from mapping: %+v --- %+v", mapping, policy) | ||
| epInfo.Policies = append(epInfo.Policies, policy) | ||
|
|
Contributor
There was a problem hiding this comment.
Code/functionallity looks fine, Stylistically I'd prefer this ACL portion in a different function.
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.