Testing: properly detect gateway interface in L2Bridge tests.#97
Merged
mdebjit merged 1 commit intomicrosoft:masterfrom Nov 2, 2023
Merged
Testing: properly detect gateway interface in L2Bridge tests.#97mdebjit merged 1 commit intomicrosoft:masterfrom
mdebjit merged 1 commit intomicrosoft:masterfrom
Conversation
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
aznashwan
force-pushed
the
fix-ci-workflow
branch
from
c2d066e to
186fe7a
Compare
Contributor
Author
|
This should prevent the seemingly inconsistent failures for the SDNBridge test as proven by these successful runs: 97, 98, and 99. Root cause of the issue was this assumption that the main Interface will always be named |
iankingori
approved these changes
Nov 2, 2023
mdebjit
approved these changes
Nov 2, 2023
Collaborator
mdebjit
left a comment
mdebjit
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
aznashwan
added a commit
to aznashwan/windows-container-networking
that referenced
this pull request
Nov 13, 2023
…oft#97) Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.