Add --implements option to scope _Impl scaffold emission#4375
Merged
Add --implements option to scope _Impl scaffold emission#4375
--implements option to scope _Impl scaffold emission#4375Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/bbdff62b-17d1-4f21-89d9-39619bdc6d80 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/bbdff62b-17d1-4f21-89d9-39619bdc6d80 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add implements option to windows-bindgen for specific interfaces
Add May 4, 2026
--implements option to scope _Impl scaffold emission
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/1d8f2160-2c59-4bbc-ae67-4edba01af9d8 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--implementhandling inwindows-bindgenimplements: Vec<String>field onBindgen,--implementsCLI arg, and.implements()builder methodImplementsmatcher type analogous toFilterImplementsintoConfig(withshould_implement(type, default)helper)_Implscaffolding ininterface.rsandcpp_interface.rsbased on the new optionlib.rsarg table)fixture.tomlkeys:implement,implements) and add abindgen/implementsfixtureimplementsandimplements_iterinto a singleimplements<I, S>(I)taking an iteratorcargo fmtto fix cpp_interface.rs indentation that broke the fmt CI jobcargo fmt --checkis clean