Skip to content

Add --implements option to scope _Impl scaffold emission#4375

Merged
kennykerr merged 5 commits intomasterfrom
copilot/add-implements-option-for-bindgen
May 4, 2026
Merged

Add --implements option to scope _Impl scaffold emission#4375
kennykerr merged 5 commits intomasterfrom
copilot/add-implements-option-for-bindgen

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

  • Investigate current --implement handling in windows-bindgen
  • Add implements: Vec<String> field on Bindgen, --implements CLI arg, and .implements() builder method
  • Add Implements matcher type analogous to Filter
  • Wire Implements into Config (with should_implement(type, default) helper)
  • Gate _Impl scaffolding in interface.rs and cpp_interface.rs based on the new option
  • Update docs (lib.rs arg table)
  • Extend the harness (fixture.toml keys: implement, implements) and add a bindgen/implements fixture
  • Collapse implements and implements_iter into a single implements<I, S>(I) taking an iterator
  • Run cargo fmt to fix cpp_interface.rs indentation that broke the fmt CI job
  • All 178 fixture tests pass and cargo fmt --check is clean

Copilot AI linked an issue May 4, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits May 4, 2026 18:13
Copilot AI changed the title [WIP] Add implements option to windows-bindgen for specific interfaces Add --implements option to scope _Impl scaffold emission May 4, 2026
Copilot AI requested a review from kennykerr May 4, 2026 18:15
@kennykerr kennykerr marked this pull request as ready for review May 4, 2026 18:15
@kennykerr kennykerr merged commit b43d04e into master May 4, 2026
30 checks passed
@kennykerr kennykerr deleted the copilot/add-implements-option-for-bindgen branch May 4, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows-bindgen the implement option is too broad

2 participants