Remove blanket --noexcept option from windows-bindgen#4385
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/4b9d6d4e-e3cb-460d-bf42-1fa6a2a68a54 Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove windows-bindgen blanket noexcept option
Remove blanket May 5, 2026
--noexcept option from windows-bindgen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-issue follow-up to #4366: the blanket
--noexceptflag did not measurably improve build times or debuggability and is being removed. The per-method[noexcept]IDL attribute (realNoExceptionAttributemetadata) is unaffected.windows-bindgen: drop the--noexceptCLI arg,Bindgen::noexcept()builder,noexceptfield, and doc-table entry (lib.rs); dropnoexceptfromConfig(config/mod.rs).types/method.rs):noexceptis now driven solely byNoExceptionAttribute. Since the only remaining noexcept path carries a metadata guarantee, theassert!/debug_assert!split collapses to a singledebug_assert!.crates/tests/fixtures/harness/data/bindgen/noexcept/) and its plumbing in the fixture harness (fixtures.rs).