Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

Japanese translation#137

Merged
craigwi merged 3 commits into
microsoft:masterfrom
mattn:japanese-translation
Apr 27, 2018
Merged

Japanese translation#137
craigwi merged 3 commits into
microsoft:masterfrom
mattn:japanese-translation

Conversation

@mattn
Copy link
Copy Markdown
Contributor

@mattn mattn commented Apr 27, 2018

add japanese translation. I looked to remove bJAPAN/bKOREAJAPAN/JAPANBEGIN/JAPANEND. But it is need to keep behavior for users who want to use english on japanese locale.

fe848e3586cb1cb4

@mattn
Copy link
Copy Markdown
Contributor Author

mattn commented Apr 27, 2018

Please want merge. Some dialogs still have problems for sizes.

image

@mattn
Copy link
Copy Markdown
Contributor Author

mattn commented Apr 27, 2018

Now ready to merge.

@mattn mattn force-pushed the japanese-translation branch from 24032f8 to 26e2db5 Compare April 27, 2018 00:24
@craigwi
Copy link
Copy Markdown
Contributor

craigwi commented Apr 27, 2018

bJapan/bJAPAN is set when the language is LANG_JAPANESE. If you are happy with the LANG_JAPANESE behavior, that's good enough for me.

@craigwi craigwi merged commit c75663d into microsoft:master Apr 27, 2018
@mattn
Copy link
Copy Markdown
Contributor Author

mattn commented Apr 27, 2018

Thanks!

@fetus-hina
Copy link
Copy Markdown

Great work.
But this translation does not appear to follow Microsoft style guide.

According to the style guide,

  • We should use a space between katakana-words. e.g. "ツール (space) バー" instead of "ツールバー". (Style guide §3.1.7)
  • Today, we should use ”-" for English suffix "-er" or "-or", e.g. "ファイル (space) マネージャー" instead of "ファイルマネージャー" or "ファイル (space) マネージャ". ("Katakana prolonged sound mark" of §3.1.14)

If you want to make a nostalgic style (win3.1, win9x and old NT style),

  • We should use Half-width katakana instead of Full-width katakana for menu bar items, e.g. "ツール(space)バー" instead of "ツールバー" or "ツール(space)バー".
  • In this case, we shouldn't use katakana prolonged sound mark for "-er" or "-or", e.g. "ファイル(space)マネージャ" instead of "ファイル マネージャ" or "ファイル マネージャー".

Note: The rule of katakana prolonged sound mark ("ー" for "-er" or "-or") has changed in 2008.

@mattn
Copy link
Copy Markdown
Contributor Author

mattn commented Apr 27, 2018

@fetus-hina Thanks your advice. I'm not familier to the guide since MS changed style recently after I learned the older style (no spaces, no suffix -er).

Could you please correct words in curent translation? Below is a file listed japanese katakana words in resource files.

https://gist.github.com/4f01bb666a0b1b5af9bf8aa71a869acf

@mattn
Copy link
Copy Markdown
Contributor Author

mattn commented Apr 27, 2018

@fetus-hina If you are going to make PR, please wait for #138 since this PR change words and dialog sizes.

@mattn
Copy link
Copy Markdown
Contributor Author

mattn commented Apr 27, 2018

Okay, I'll fix with spaces and suffix -er in my self. Sorry.

@mattn mattn mentioned this pull request Apr 27, 2018
@clzls
Copy link
Copy Markdown
Contributor

clzls commented Apr 29, 2018

I think we may not leave Japanese translations in res_en-US.rc.

Since localization for many countries and languages are working in process, it's not a good idea to contain Japanese translations for them (for example res_zh-CN.rc and res_pl-PL.rc now).

@craigwi
Translators from other countries can't read Japanese words and just make a copy of res_en-US.rc for their work. So JAPANBEGIN and JAPANEND may leave many rubbish in their works.

@craigwi
Copy link
Copy Markdown
Contributor

craigwi commented Apr 30, 2018

There seems to be a different of opinion on whether to leave the JAPANBEGIN/END stuff in or not. My request is for someone who can figure out what is going on to propose a specific change. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants