Show license agreements when installing#1347
Merged
Merged
Conversation
added 16 commits
August 2, 2021 15:40
florelis
commented
Aug 6, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
| "description": "The agreement URL." | ||
| } | ||
| }, | ||
| "minProperties": 1 |
Contributor
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 19, 2021
yao-msft
reviewed
Aug 20, 2021
yao-msft
reviewed
Aug 20, 2021
yao-msft
reviewed
Aug 20, 2021
yao-msft
reviewed
Aug 20, 2021
yao-msft
reviewed
Aug 20, 2021
yao-msft
reviewed
Aug 20, 2021
yao-msft
approved these changes
Aug 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds showing license agreements when installing and the ability to accept them with a command line argument.
The output with the agreements looks like this:
Not in this PR:
I still have to check more cases manually to confirm that the experience is good (specially around upgrade all, import and dependencies).
Microsoft Reviewers: Open in CodeFlow