Skip to content

Add comments to loc strings#6150

Merged
florelis merged 2 commits intomicrosoft:masterfrom
florelis:loccomments
Apr 17, 2026
Merged

Add comments to loc strings#6150
florelis merged 2 commits intomicrosoft:masterfrom
florelis:loccomments

Conversation

@florelis
Copy link
Copy Markdown
Member

@florelis florelis commented Apr 16, 2026

Related to #6148. I asked Copilot to go through our strings to add comments to anything that was ambiguous or translated incorrectly in some language. Updating the comments does not trigger a re-translation, so we still need to submit a bug to the loc team.

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner April 16, 2026 19:54
Comment thread doc/Developing.md
Comment thread src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw Outdated
@JohnMcPMS
Copy link
Copy Markdown
Member

Updating the comments does not trigger a re-translation, so we still need to submit a bug to the loc team.

That is annoying; do you know if we change the symbol name and comment it would trigger? As in, we update the comment and change it to LocalizedStringResourceName2.

@florelis
Copy link
Copy Markdown
Member Author

Updating the comments does not trigger a re-translation, so we still need to submit a bug to the loc team.

That is annoying; do you know if we change the symbol name and comment it would trigger? As in, we update the comment and change it to LocalizedStringResourceName2.

I'm not sure. I know in some cases if they see that a string is the same as another they may just use the same translation, but I don't know if they consider comments.

@florelis florelis merged commit a7a2300 into microsoft:master Apr 17, 2026
9 checks passed
@florelis florelis deleted the loccomments branch April 17, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants