Skip to content

Make sfs-client a vcpkg port#6243

Merged
florelis merged 6 commits into
microsoft:masterfrom
florelis:sfs-client
May 27, 2026
Merged

Make sfs-client a vcpkg port#6243
florelis merged 6 commits into
microsoft:masterfrom
florelis:sfs-client

Conversation

@florelis
Copy link
Copy Markdown
Member

@florelis florelis commented May 22, 2026

📖 Description

Removes the git-subtree for sfs-client and replaces it with a local vcpkg port. This port is based on the template provided by sfs-client

  • Updated the script that creates a local overlay to fetch this port.
  • Added a small patch to fix a build error in the port.
  • Created a new folder for the custom port patches. This means duplicating the files, but prevents losing them when re-creating the ports.
  • Added a job to the build pipeline to ensure that the ports still match what the creation script produces, to ensure they're kept in sync.

This fixes a CG alert for c-ares triggered by having sfs-client's cgmanifest checked in, which caused CG to consider that as the version used despite us updating the dependency.

🔗 References

🔍 Validation

It builds :D

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner May 22, 2026 01:37
Comment thread azure-pipelines.yml Outdated
@florelis florelis merged commit e270ee3 into microsoft:master May 27, 2026
9 checks passed
@florelis florelis deleted the sfs-client branch May 27, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants