Skip to content

Ensure portable command alias does not escape directory#6251

Merged
florelis merged 2 commits into
microsoft:masterfrom
florelis:portableAlias
May 27, 2026
Merged

Ensure portable command alias does not escape directory#6251
florelis merged 2 commits into
microsoft:masterfrom
florelis:portableAlias

Conversation

@florelis
Copy link
Copy Markdown
Member

@florelis florelis commented May 26, 2026

📖 Description

This adds validation to ensure that a PortableCommandAlias does not use relative paths to point outside of its directory. It uses the same validation we already have for RelativeFilePath

🔗 References

🔍 Validation

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner May 26, 2026 20:42
Comment thread src/AppInstallerSharedLib/Filesystem.cpp Outdated
@florelis florelis merged commit ab31639 into microsoft:master May 27, 2026
9 checks passed
@florelis florelis deleted the portableAlias branch May 27, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants