Skip to content

Throw if npm install returns non-zero exit code#252

Merged
AmelBawa-msft merged 1 commit intomicrosoft:mainfrom
guillermooo:users/guillermo/bugfix/npmdsc-false-positives
Apr 28, 2026
Merged

Throw if npm install returns non-zero exit code#252
AmelBawa-msft merged 1 commit intomicrosoft:mainfrom
guillermooo:users/guillermo/bugfix/npmdsc-false-positives

Conversation

@guillermooo
Copy link
Copy Markdown
Contributor

@guillermooo guillermooo commented Mar 13, 2026

Closes #251

PS> invoke-DscResource -ModuleName NpmDsc -Name NpmPackage -Method set -Property @{ Name = 'mariozechner/pi-coding-agent'; Global = $true }
Exception: Command 'npm install mariozechner/pi-coding-agent -g' failed: error code 128; error An unknown git error occurred; error command git --no-replace-objects ls-remote ssh://git@github.com/mariozechner/pi-coding-agent.git; error git@github.com: Permission denied (publickey).; error fatal: Could not read from remote
repository.; error Please make sure you have the correct access rights; error and the repository exists.; error A complete log of this run can be found in: C:\Users\xxx\AppData\Local\npm-cache\_logs\2026-03-13T20_02_00_172Z-debug-0.log


Microsoft Reviewers: Open in CodeFlow

@guillermooo guillermooo marked this pull request as ready for review March 13, 2026 20:04
@denelon
Copy link
Copy Markdown
Collaborator

denelon commented Apr 13, 2026

@guillermooo can you update the branch for this PR?

@guillermooo guillermooo force-pushed the users/guillermo/bugfix/npmdsc-false-positives branch from d399cd2 to b0d4156 Compare April 22, 2026 06:06
@guillermooo
Copy link
Copy Markdown
Contributor Author

@denelon Done!

@denelon
Copy link
Copy Markdown
Collaborator

denelon commented Apr 22, 2026

Thanks! I'll ask someone to review the changes.

@AmelBawa-msft
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@AmelBawa-msft
Copy link
Copy Markdown
Contributor

Test failure is unrelated to this change

@AmelBawa-msft AmelBawa-msft merged commit 9f3ba6a into microsoft:main Apr 28, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NpmDsc false positive when installing foo/bar vs @foo/bar

3 participants