Skip to content

Add Nsis 3.05#1064

Merged
1 commit merged intomicrosoft:masterfrom
latere-a-latere:NSIS-3.05
May 28, 2020
Merged

Add Nsis 3.05#1064
1 commit merged intomicrosoft:masterfrom
latere-a-latere:NSIS-3.05

Conversation

@latere-a-latere
Copy link
Contributor

@latere-a-latere latere-a-latere commented May 25, 2020

Please note that the package name of this PR currently conflicts with existing PR #975. In my opinion the portable edition being added in that PR shouldn't hold the package name NSIS.NSIS.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 25, 2020
@ghost ghost assigned RDMacLachlan May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

This submission has moved to manual review.

@LukasNespor
Copy link
Contributor

Please note that the package name of this PR currently conflicts with existing PR #975. In my opinion the portable edition being added in that PR shouldn't hold the package name NSIS.NSIS.

Microsoft Reviewers: Open in CodeFlow

I already changed all my PRs and added Portable suffix e.g. NSIS.NSISPortable

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 5037d96 into microsoft:master May 28, 2020
@latere-a-latere latere-a-latere deleted the NSIS-3.05 branch June 1, 2020 08:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants