Skip to content

Add Battle for Wesnoth 1.14.12#1095

Merged
2 commits merged intomicrosoft:masterfrom
latere-a-latere:Wesnoth-1.14.12
May 30, 2020
Merged

Add Battle for Wesnoth 1.14.12#1095
2 commits merged intomicrosoft:masterfrom
latere-a-latere:Wesnoth-1.14.12

Conversation

@latere-a-latere
Copy link
Contributor

@latere-a-latere latere-a-latere commented May 25, 2020

Currently awaiting smartscreen clearance

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

MarNicGit The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 25, 2020
@ghost ghost assigned RDMacLachlan May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

This submission has moved to manual review.

@latere-a-latere
Copy link
Contributor Author

Smartscreen has cleared the file, PR is now ready for review
image

@latere-a-latere latere-a-latere marked this pull request as ready for review May 26, 2020 06:14
@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label May 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 61304ad into microsoft:master May 30, 2020
@latere-a-latere latere-a-latere deleted the Wesnoth-1.14.12 branch June 1, 2020 08:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants