Skip to content

Delete manifests/a/ArmCord directory#182322

Closed
SomeAspy wants to merge 1 commit into
microsoft:masterfrom
Legcord:master
Closed

Delete manifests/a/ArmCord directory#182322
SomeAspy wants to merge 1 commit into
microsoft:masterfrom
Legcord:master

Conversation

@SomeAspy
Copy link
Copy Markdown
Contributor

@SomeAspy SomeAspy commented Oct 12, 2024

ArmCord has been DMCA'd by ARM LLC.
We are rebranding to legcord, and starting versioning from 1.0.0

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

ArmCord has been DMCA'd by ARM LLC.
We are rebranding to legcord, and starting versioning from 1.0.0
@wingetbot
Copy link
Copy Markdown
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@SomeAspy
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Oct 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback This needs a response from the author. label Oct 12, 2024
@SomeAspy
Copy link
Copy Markdown
Contributor Author

This is indeed, an abnormal PR. I looked looked around a bit to see if there was a defined process for deleting a package, but didn't find one.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 12, 2024
@stephengillie
Copy link
Copy Markdown
Collaborator

URL: https://github.com/ArmCord/ArmCord/releases/download/v3.0.8/ArmCord.Setup.3.0.8.exe
Status Code: 200

(Automated message - build 896)

@SomeAspy
Copy link
Copy Markdown
Contributor Author

I understand they still exist, but they are a redirect to to the legcord releases pages, which are still under the name armcord
We will be removing these builds, as we are restarting versioning from 1.0.0.
https://github.com/Legcord/Legcord/releases/tag/v1.0.0

@stephengillie
Copy link
Copy Markdown
Collaborator

URL: https://github.com/ArmCord/ArmCord/releases/download/v3.0.8/ArmCord.Setup.3.0.8.exe
Status Code: 200

(Automated message - build 896)

@stephengillie
Copy link
Copy Markdown
Collaborator

URL: https://github.com/ArmCord/ArmCord/releases/download/v3.0.8/ArmCord.Setup.3.0.8.exe
Status Code: 200

(Automated message - build 897)

1 similar comment
@stephengillie
Copy link
Copy Markdown
Collaborator

URL: https://github.com/ArmCord/ArmCord/releases/download/v3.0.8/ArmCord.Setup.3.0.8.exe
Status Code: 200

(Automated message - build 897)

@SomeAspy
Copy link
Copy Markdown
Contributor Author

Hi @Trenly
I hope this is not a bother, but I'm not sure what else to do here.
The bot seems to be stuck at the fact that the download links are still up
Would you be able to override this?
Thanks!

@Trenly
Copy link
Copy Markdown
Contributor

Trenly commented Oct 19, 2024

@SomeAspy - The validation and publishing pipelines can only change one manifest at a time. You will need to submit separate PRs removing each version

@SomeAspy
Copy link
Copy Markdown
Contributor Author

Oh I see, I will do that in a moment, Thank you

@SomeAspy SomeAspy closed this Oct 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PullRequest-Error PR is Invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants