Skip to content

Conversation

@rozmansi
Copy link
Contributor

@rozmansi rozmansi commented Apr 7, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-246151-20250407-1

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Apr 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 7, 2025
@rozmansi
Copy link
Contributor Author

rozmansi commented Apr 8, 2025

I have verified the MSI URL the manifest is pointing to is correct. The MSI downloads and the SHA256 is correct. winget install --manifest <path> also works. Downloads MSI and installs it without any issues.

Might there be any bandwidth throttling or other limitations for accessing codeberg.org downloads from Microsoft servers?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 8, 2025
@stephengillie
Copy link
Collaborator

Hi @rozmansi,

Part of the concern here, I believe, is that some 3rd party sites can also be used to rehost packages. So packages from these domains require additional human review. Sorry for the delay on this.

The PublisherUrl links to the domain used by the InstallerUrl. The page itself is down currently, and I"ll approve this with the assumption that this is a temporary situation.
image

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 16, 2025 15:49
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f7f2fcd into microsoft:master Apr 16, 2025
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 16, 2025
@rozmansi
Copy link
Contributor Author

The PublisherUrl links to the domain used by the InstallerUrl. The page itself is down currently, and I"ll approve this with the assumption that this is a temporary situation. image

Indeed, the site was down at that time.

Thank you for approving it.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants