Skip to content

Conversation

@emendelson
Copy link
Contributor

@emendelson emendelson commented Apr 11, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247526-20250411-1

@emendelson
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Apr 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 11, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 1042.)

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 12, 2025 01:57
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

2025-04-16 17:11:47.768 [FAIL] C:__w\1\s\external\pkg\src\AppInstallerSharedLib\SHA256.cpp(161)\WindowsPackageManager.dll!00007FF8CD5E6AAB: (caller: 00007FF8CD63D50C) Exception(1) tid(1734) 8A150040
2025-04-16 17:12:30.255 [CLI ] Package hash verification failed. SHA256 in manifest [492235d911f9e7643f2a566c2648ad6461f00c9f62443220981a43992e0fa645] does not match download [91de26048773db7bd306e9294ac179c9567e253a7d172aead254956ea981706b] with file size [91550568] and content type [application/x-msdownload]

(Automated response - build 1044.)

Installers:
- Architecture: neutral
InstallerUrl: https://mendelson.org/wpdos/vDosWP-Setup.exe
InstallerSha256: 492235D911F9E7643F2A566C2648AD6461F00C9F62443220981A43992E0FA645
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerSha256: 492235D911F9E7643F2A566C2648AD6461F00C9F62443220981A43992E0FA645
InstallerSha256: 91DE26048773DB7BD306E9294AC179C9567E253A7D172AEAD254956EA981706B

@stephengillie stephengillie added Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. and removed Changes-Requested Changes Requested labels Apr 17, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Apr 22, 2025
@ItzLevvie
Copy link
Contributor

Close with reason: Stale pull request;

@microsoft-github-policy-service microsoft-github-policy-service bot removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Apr 22, 2025
auto-merge was automatically disabled April 22, 2025 22:06

Pull request was closed

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants