Skip to content

Conversation

@DuckDuckStudio
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio commented Apr 12, 2025

Add DisplayVersion to the manifest.


Microsoft Reviewers: Open in CodeFlow

Add DisplayVersion to the manifest.
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247761-20250412-1

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Apr 12, 2025
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247761-20250412-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Apr 12, 2025
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 12, 2025
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-247761-20250412-3

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Apr 12, 2025
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 12, 2025 11:22
@stephengillie
Copy link
Collaborator

Hi @DuckDuckStudio,

This manifest uses the same values for DisplayVersion and PackageVersion. This is not recommended, and the DisplayVersion should be removed.

(Automated response - build 1042.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 12, 2025
@DuckDuckStudio
Copy link
Contributor Author

Hi @DuckDuckStudio,

This manifest uses the same values for DisplayVersion and PackageVersion. This is not recommended, and the DisplayVersion should be removed.

(Automated response - build 1042.)

CC @denelon - This is the reason why I didn't add the DisplayVersion in my previous PR.

@stephengillie - This is why this modification PR was submitted.
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 12, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 16, 2025
@ItzLevvie
Copy link
Contributor

[Policy] Needs-Attention

cc @DuckDuckStudio: @denelon is currently out of the office and will be back on Monday, the 21st of April 2025.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 16, 2025
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 16, 2025
@stephengillie
Copy link
Collaborator

Hi @DuckDuckStudio,
This manifest uses the same values for DisplayVersion and PackageVersion. This is not recommended, and the DisplayVersion should be removed.
(Automated response - build 1042.)

CC @denelon - This is the reason why I didn't add the DisplayVersion in my previous PR.

@stephengillie - This is why this modification PR was submitted. image

Thanks - I've added it to the exception list for this check.

@stephengillie
Copy link
Collaborator

stephengillie commented Apr 16, 2025

Edit: fixing...

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d954149 into microsoft:master Apr 16, 2025
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 16, 2025
@DuckDuckStudio DuckDuckStudio deleted the ppy.osu-2025.321.0-202504120914 branch April 16, 2025 18:32
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Author-Feedback This needs a response from the author. Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants