Skip to content

Conversation

@UnownPlain
Copy link
Contributor

@UnownPlain UnownPlain commented Apr 17, 2025

Pull request has been created with komac v2.11.2 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-249239-20250417-1

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-249239-20250417-2

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 18, 2025
@wingetbot
Copy link
Collaborator

=== manifests\p\Plex\PlexMediaServer\1.41.6.9685 ===
Missing Properties value based on version 1.41.5.9522:

  • InstallerLocale
  • Platform
  • InstallerType
  • Scope
  • ProductCode
  • Dependencies
  • ElevationRequirement
  • AppsAndFeaturesEntries

@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 18, 2025 01:00
@stephengillie
Copy link
Collaborator

=== manifests\p\Plex\PlexMediaServer\1.41.6.9685 === Missing Properties value based on version 1.41.5.9522:

  • InstallerLocale
  • Platform
  • InstallerType
  • Scope
  • ProductCode
  • Dependencies
  • ElevationRequirement
  • AppsAndFeaturesEntries

Hi @UnownPlain,

This is quite a few properties to lose. Can any of them be added?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Apr 22, 2025
@UnownPlain
Copy link
Contributor Author

=== manifests\p\Plex\PlexMediaServer\1.41.6.9685 === Missing Properties value based on version 1.41.5.9522:

  • InstallerLocale
  • Platform
  • InstallerType
  • Scope
  • ProductCode
  • Dependencies
  • ElevationRequirement
  • AppsAndFeaturesEntries

Hi @UnownPlain,

This is quite a few properties to lose. Can any of them be added?

Most of these properties are under Installers now

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 22, 2025
@stephengillie stephengillie removed Needs-Attention This work item needs to be reviewed by a member of the core team. Manifest-Metadata-Consistency labels Apr 22, 2025
@stephengillie
Copy link
Collaborator

Hi @UnownPlain,

This manifest uses the same values for DisplayVersion and PackageVersion. This is not recommended, and the DisplayVersion should be removed.

(Automated response - build 1046.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 22, 2025
auto-merge was automatically disabled April 22, 2025 17:33

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-57-249239-20250422-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed New-Manifest labels Apr 22, 2025
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 22, 2025
@wingetbot
Copy link
Collaborator

=== manifests\p\Plex\PlexMediaServer\1.41.6.9685 ===
Missing Properties value based on version 1.41.5.9522:

  • InstallerLocale
  • Platform
  • InstallerType
  • Scope
  • ProductCode
  • Dependencies
  • ElevationRequirement
  • AppsAndFeaturesEntries

@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 22, 2025 19:00
@UnownPlain
Copy link
Contributor Author

See comment above #249239 (comment)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 2fdb9ed into microsoft:master Apr 23, 2025
1 check passed
@UnownPlain UnownPlain deleted the Plex.PlexMediaServer-1.41.6.9685-AD1C3A590CA1462DA2B44AF7F43AE5F9 branch April 23, 2025 17:37
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Metadata-Consistency Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants