Skip to content

Conversation

@Macleykun
Copy link
Contributor

@Macleykun Macleykun commented May 22, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-259233-20250522-1

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-259233-20250522-2

@Macleykun
Copy link
Contributor Author

image
Also wanted to show i've localy validated and the package does install as intended. It will ask for an admin prompt and then install nicely.

I'll add the package dependency aswell, as i notice that's missing. Feel free to give feedback!

This change also has been checked locally.
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-61-259233-20250522-3

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 22, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 22, 2025 21:30
@stephengillie
Copy link
Collaborator

Verify:
image

@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 259360c into microsoft:master May 27, 2025
1 check passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Macleykun Macleykun deleted the OpenRGB.OpenRGB-1.0rc1-c53380c2-5506-4208-9f93-2397cb4154ee branch May 28, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants