-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New version: Microsoft.Edit version 1.1.0 #261303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version: Microsoft.Edit version 1.1.0 #261303
Conversation
|
Validation Pipeline Run WinGetSvc-Validation-61-261303-20250528-1 |
|
FWIW the "executable error" validation response is because we don't write a version message out to stdout when redirected. We should, but failing to detect that is a winget validation issue rather than a product issue. |
Could you add issues for those to winget and Edit respectively? |
|
Well, good and bad news. I was slightly wrong about what the issue is, and we won't be fixing it in Edit.
WinGet validation appears to require--or desire?--that a console subsystem application do so. To quote johnmcp:
|
|
The issue appears to be that Edit does not like it when it receives a redirected output handle. The process exits with a value of 1 and outputs "Error 0x80070006: The handle is invalid." I can repro locally with |
|
We can probably make the behavior comprehensible for 1.2, but either way it's gonna just keep running rather than exiting. Vim does that, for example - it just writes the output of the editor screen to the redirected file ;P |
|
Manually validated. |
I believe that we are happy as long as the process runs for 10 seconds; the goal is that the package is "functional", not missing static dependencies or the wrong architecture, etc. |
|
Automatic Validation ended with:
(Automated response - build 1058.) |
|
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
|
@wingetbot installationmetadata exe add edit.exe --version |
1 similar comment
|
@wingetbot installationmetadata exe add edit.exe --version |
|
@DHowett, only "maintainers" can call wingetbot to do things. It might not work since the PR has already been merged. |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow