Skip to content

Origin v10.5.77.42374#2621

Closed
OfficialEsco wants to merge 1 commit intomicrosoft:masterfrom
OfficialEsco:patch-3
Closed

Origin v10.5.77.42374#2621
OfficialEsco wants to merge 1 commit intomicrosoft:masterfrom
OfficialEsco:patch-3

Conversation

@OfficialEsco
Copy link
Copy Markdown
Contributor

@OfficialEsco OfficialEsco commented Jul 25, 2020 •
edited by ghost
Loading

Dependency: VC++2015-2019Redist-x86

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?
Microsoft Reviewers: Open in CodeFlow

@OfficialEsco
Origin v10.5.77.42374
237a617 
Dependency: VC++2015-2019Redist-x86
@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented Jul 25, 2020

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 25, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Jul 25, 2020
@ghost ghost assigned msftrubengu Jul 25, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 25, 2020

The pull request encountered an internal error and has been assigned to a developer to investigate.

@KevinLaMS
Copy link
Copy Markdown
Contributor

KevinLaMS commented Jul 26, 2020

/azp run

@ghost ghost removed the Internal-Error An unidentified error occurred in the validation pipeline label Jul 26, 2020
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 26, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Jul 26, 2020
@ghost ghost assigned zachcarp Jul 26, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 26, 2020

The pull request encountered an internal error and has been assigned to a developer to investigate.

@msftrubengu
Copy link
Copy Markdown
Collaborator

msftrubengu commented Jul 27, 2020

/azp run

@ghost ghost removed the Internal-Error An unidentified error occurred in the validation pipeline label Jul 27, 2020
@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 27, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 27, 2020
@ghost ghost assigned denelon Jul 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 27, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. Validation-VCRuntime-Dependency labels Jul 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jul 27, 2020

Greetings. This package fails because it is dependent on the Visual Studio Runtime and we do not support the dependencies yet. See issue: microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 27, 2020
@KevinLaMS
Copy link
Copy Markdown
Contributor

KevinLaMS commented Jul 27, 2020 •
edited
Loading

image
tweaked image

@ghost ghost assigned OfficialEsco Jul 27, 2020
@OfficialEsco
Copy link
Copy Markdown
Contributor Author

OfficialEsco commented Jul 28, 2020 •
edited
Loading

What do you mean by

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

I wrote in the original post which dependency it needed, which should be vc_redist.x86.exe (vc2015)

Thought it would be ok since Origin was already merged, but i just checked the merged manifest and it appears to be a glitch that made it pass

@OfficialEsco
Copy link
Copy Markdown
Contributor Author

OfficialEsco commented Dec 25, 2020

closing since there is a new one

@OfficialEsco OfficialEsco deleted the patch-3 branch December 25, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Blocking-Issue Manifest validation is blocked by a known issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@OfficialEsco @wingetbot @KevinLaMS @msftrubengu @zachcarp @denelon