Skip to content

Conversation

@FaffeF
Copy link
Contributor

@FaffeF FaffeF commented Jul 25, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Pull request has been created with komac v2.12.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-277928-20250725-1

@FaffeF
Copy link
Contributor Author

FaffeF commented Jul 25, 2025

Closes #277928

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jul 25, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

  Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\lnav.exe returned exit code: -1073741515
Hex Dec Inverted Dec Symbol Description
C0000135 -1073741515 3221225781 STATUS_DLL_NOT_FOUND Possibly due to a missing dependency. (The most common dependency is Microsoft.VCRedist.2015+.x64 / .x86)

(Automated response - build 1091.)

@FaffeF FaffeF marked this pull request as draft July 25, 2025 23:02
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

 2025-07-25 16:21:10.021 [FAIL] Installer failed security check. Url: https://github.com/tstack/lnav/releases/download/v0.13.0/lnav-0.13.0-windows-x86_64.zip Result: 0x80004005
Hex Dec Inverted Dec Symbol Description
80004005 -2147467259 2147500037 E_Fail Resource missing

(Automated response - build 1091.)

@Dragon1573
Copy link
Contributor

Closes #277928

Hi @FaffeF, 👋🏼

Tip

Close keywords are only valid in your commit messages or pull request descriptions.

Editing your description is required. 🙏🏼

@FaffeF
Copy link
Contributor Author

FaffeF commented Jul 26, 2025

Sorry, must have been drunk. Updated the description.

Though this doesn't seem as straightformard as I imagined, there seems to be some unresolved dependency, and Defender is deleting the downloaded file when installing. Not sure how to fix that

@Dragon1573
Copy link
Contributor

It's still "unlinked", the issue isn't shown in "Development" section. Maybe use following markdown:

- [x] Is there a linked issue? Resolve #277927

... and Defender is deleting the downloaded file when installing.

😕 Malware hasn't been detected on my Microsoft Defender instance.

I installed as expected, but it seems this package requires a Unix-like environment, such as MinGW / Cygwin.

@Dragon1573
Copy link
Contributor

Note

In their README.md, I didn't find anything related to Windows build. I think this package is mostly aim for macOS / Linux users those need to view logs.

@FaffeF
Copy link
Contributor Author

FaffeF commented Jul 26, 2025

There is a Windows build, but it's absolutely not as ready as the mature Linux builds. It would be useful to have this great tool available on Windows without resorting to WSL or a VM. I'll see if I can figure out the syntax for the description, I wasn't aware the issue was supposed to react before the merge.

@FaffeF
Copy link
Contributor Author

FaffeF commented Jul 26, 2025

Also, the readme is probably not the most up-to-date part of the documentation. There is an lnav issue to document the Windows installation better.

@FaffeF FaffeF marked this pull request as ready for review July 26, 2025 18:06
@FaffeF FaffeF marked this pull request as draft July 26, 2025 18:06
@FaffeF
Copy link
Contributor Author

FaffeF commented Jul 26, 2025

😕 Malware hasn't been detected on my Microsoft Defender instance.

I installed as expected, but it seems this package requires a Unix-like environment, such as MinGW / Cygwin.

Then I don't know what Defender is doing here. The last RC was fine.

There is an included msys2.dll that I think is supposed to provide what's needed. Trying to get some more info from the developer.

@FaffeF
Copy link
Contributor Author

FaffeF commented Jul 30, 2025

Ok, Defender is no longer complaining, but it seems that lnav needs to find the terminfo file by way of $env:TERMINFO_DIRS = "/cygdrive/c/Users/.../AppData/Local/Microsoft/WinGet/Packages/tstack.lnav__DefaultSource/lnav-0.13.0/lib/terminfo"

Not sure if this is possible to accomplish, I can't think of a way to set that variable. The developer is working on removing this dependency.

@FaffeF FaffeF changed the title New package: tstack.lnav version 0.13.0 New package: tstack.lnav version 0.13.1-beta1 Aug 4, 2025
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-277928-20250804-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error New-Package labels Aug 4, 2025
@FaffeF FaffeF marked this pull request as ready for review August 4, 2025 17:59
@FaffeF
Copy link
Contributor Author

FaffeF commented Aug 4, 2025

with the latest beta changes there is no longer a dependency on external files

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error New-Package labels Aug 20, 2025
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Aug 20, 2025
@FaffeF
Copy link
Contributor Author

FaffeF commented Aug 20, 2025

Ok, this is the same message as above, and manual installation and testing in a clean Windows sandbox reveals no missing dependencies. The developer states that no external dependencies are needed.

Does this automated testing work in some way which prevents lnav from accessing msys-2.0.dll, which is unpacked into the same directory? The exit code is consistent with what happens if I manually rename that file.

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Aug 20, 2025

[Policy] Needs-Manual-Merge

@FaffeF FaffeF changed the title New package: tstack.lnav version 0.13.1-beta3 New package: tstack.lnav version 0.13.1-beta4 Aug 20, 2025
@microsoft-github-policy-service
Copy link
Contributor

Hello @FaffeF,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer and removed Needs-Author-Feedback This needs a response from the author. labels Aug 20, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\lnav.exe returned exit code: -1073741515

Hex Dec Inverted Dec Symbol Description
C0000135 -1073741515 3221225781 STATUS_DLL_NOT_FOUND Possibly due to a missing dependency. (The most common dependency is Microsoft.VCRedist.2015+.x64 / .x86)

(Automated response - build 1105.)

@stephengillie
Copy link
Collaborator

Manual Validation isn't seeing this error.

Verify:
image

@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 20, 2025
@stephengillie stephengillie merged commit 70d3b1a into microsoft:master Aug 20, 2025
1 check passed
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Installation-Error Error installing application Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer labels Aug 20, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 20, 2025
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@microsoft-github-policy-service microsoft-github-policy-service bot added Publish-Pipeline-Succeeded and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 20, 2025
@FaffeF
Copy link
Contributor Author

FaffeF commented Aug 20, 2025

great, thanks!

@FaffeF FaffeF deleted the tstack.lnav-0.13.0-C4BBE38924334E39BE4D86D591E86066 branch August 20, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Package Request]: lnav

7 participants