Skip to content

Add NuShell-0.18.1.#3221

Closed
yigitemres wants to merge 1 commit intomicrosoft:masterfrom
yigitemres:nushell-0.18.1
Closed

Add NuShell-0.18.1.#3221
yigitemres wants to merge 1 commit intomicrosoft:masterfrom
yigitemres:nushell-0.18.1

Conversation

@yigitemres
Copy link
Copy Markdown
Contributor

@yigitemres yigitemres commented Aug 24, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 24, 2020
@ghost
Copy link
Copy Markdown

ghost commented Aug 24, 2020

This submission has moved to manual review.

@ghost ghost assigned KevinLaMS Aug 24, 2020
Comment on lines +16 to +18
Switches:
Silent: /quiet /norestart
SilentWithProgress: /passive /norestart
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are automatically set for the msi installertype

@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Aug 25, 2020
@ghost
Copy link
Copy Markdown

ghost commented Aug 25, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying WDNotify@microsoft.com for investigation.

@ghost ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Aug 25, 2020
@KevinLaMS KevinLaMS added Validation-VCRuntime-Dependency and removed Needs SmartScreen Investigation Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation labels Aug 27, 2020
@ghost
Copy link
Copy Markdown

ghost commented Aug 27, 2020

Greetings. This package fails because it is dependent on the Visual Studio Runtime and we do not support the dependencies yet. See issue: microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

@ghost ghost added Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. labels Aug 27, 2020
@ghost ghost assigned yigitemres Aug 27, 2020
@KevinLaMS
Copy link
Copy Markdown
Contributor

KevinLaMS commented Aug 27, 2020

the apps are failing to run from a missing dependency.

removed image

@yigitemres yigitemres closed this Aug 27, 2020
@yigitemres yigitemres deleted the nushell-0.18.1 branch August 27, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocking-Issue Manifest validation is blocked by a known issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants