Skip to content

Conversation

@Tiptup300
Copy link

@Tiptup300 Tiptup300 commented Jan 11, 2026

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-122-329406-20260111-1

@Tiptup300
Copy link
Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 11, 2026
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual Validation ended with:
image
image

PackageVersion: 1.0.0
InstallerType: wix
ProductCode: '{7F6BE12B-A852-4E8B-9CA6-56071464E32D}'
Installers:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installers:
Dependencies:
PackageDependencies:
- PackageIdentifier: Microsoft.DotNet.DesktopRuntime.10
Installers:

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 14, 2026
stephengillie
stephengillie previously approved these changes Jan 14, 2026
@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 14, 2026
…aller.yaml

Co-authored-by: Stephen Gillie <114952565+stephengillie@users.noreply.github.com>
auto-merge was automatically disabled January 14, 2026 03:05

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-122-329406-20260114-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jan 14, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Validation-Completed Validation passed labels Jan 14, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot removed Changes-Requested Changes Requested Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jan 14, 2026
@Tiptup300
Copy link
Author

@stephengillie

I apologize, I believe I made a mistake. I chose Mark as resolved thinking it room your change. A moment later I unresolved and committed your suggestion, but I think the bots responded already and possibly put this in a bad state.

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-122-329406-20260114-2

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

Copy link
Author

@Tiptup300 Tiptup300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (test)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "All comments must be resolved.",
"documentation_url": "https://docs.github.com/articles/about-protected-branches",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"94d2fe9bc6afebe818a82836b576ad10a08d79c9"}

(Automated response - build 1195.)

@Tiptup300 Tiptup300 closed this Jan 15, 2026
auto-merge was automatically disabled January 15, 2026 22:33

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants