Skip to content

New version: M-Igashi.headroom version 1.7.2#350443

Merged
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom
M-Igashi:M-Igashi.headroom-1.7.2
Mar 23, 2026
Merged

New version: M-Igashi.headroom version 1.7.2#350443
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom
M-Igashi:M-Igashi.headroom-1.7.2

Conversation

@M-Igashi
Copy link
Contributor

@M-Igashi M-Igashi commented Mar 20, 2026

New version: M-Igashi.headroom version 1.7.2

  • Update mp3rgain to 2.0.3
  • Update console to 0.16, indicatif to 0.18, and other dependency updates
  • Internal code simplification
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-136-350443-20260320-1

@wingetbot wingetbot added New-Manifest Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Mar 20, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 20, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Mar 20, 2026
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

2026-03-20 11:53:41.481 [FAIL] Installer failed security check. Url: https://github.com/M-Igashi/headroom/releases/download/v1.7.2/headroom-v1.7.2-windows-x86_64.zip Result: 0x80004005
Detection: Trojan:Win32/Sprisky.U!cl
Defender Security Intelligence version: 1.445.591.0

Hex Dec Inverted Dec Symbol Description
80004005 -2147467259 2147500037 E_Fail Resource missing

(Automated response - build 1237.)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 20, 2026
@M-Igashi
Copy link
Contributor Author

False Positive: Trojan:Win32/Sprisky.U!cl

This is a false positive detection. Here is the evidence:

1. Built from source by GitHub Actions on windows-latest

The binary was compiled from Rust source code entirely within GitHub Actions CI:

2. Fully open-source and auditable

3. Rust binaries are known to trigger heuristic false positives

Rust's standard library statically links system functionality (thread management, panic handling, memory allocation) which can resemble patterns flagged by heuristic scanners. This is a well-documented issue in the Rust community.

Action taken

I have submitted the installer to Microsoft Defender for analysis via https://www.microsoft.com/en-us/wdsi/filesubmission as a false positive.

Request

Could you please re-run the validation once the Defender definitions are updated? Thank you.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 20, 2026
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-136-350443-20260320-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest Validation-Defender-Error labels Mar 20, 2026
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

2026-03-20 15:39:30.347 [FAIL] Installer failed security check. Url: https://github.com/M-Igashi/headroom/releases/download/v1.7.2/headroom-v1.7.2-windows-x86_64.zip Result: 0x80004005
Detection: Trojan:Script/Wacatac.H!ml
Defender Security Intelligence version: 1.445.591.0

Hex Dec Inverted Dec Symbol Description
80004005 -2147467259 2147500037 E_Fail Resource missing

(Automated response - build 1237.)

@M-Igashi
Copy link
Contributor Author

This is a false positive. The detection name changed between validation runs (Trojan:Win32/Sprisky.U!clTrojan:Script/Wacatac.H!ml), which is a strong indicator of heuristic-based false detection rather than actual malware.

This binary is a standard Rust CLI tool built by GitHub Actions CI with no post-processing. The source code, build workflow, and build logs are fully transparent:

I have submitted the file to Microsoft Security Intelligence for analysis (Submission ID: 7ae605d9-e619-4272-a30e-27ae15cff8a9). Once Microsoft confirms the false positive and updates their definitions, I will request re-validation.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Mar 20, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest labels Mar 21, 2026
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-136-350443-20260321-1

@M-Igashi
Copy link
Contributor Author

Thank you for re-running the validation, @stephengillie.

The security check appears to have passed this time, but the validation now fails with an installation error. Could you share the detailed installation log so I can investigate the root cause?

Possible causes I'm considering:

  1. Defender real-time protection may still be blocking the binary at install time (even though the scan step passed), since the false positive submission is still under review by Microsoft.
  2. FFmpeg dependency — the manifest declares Gyan.FFmpeg as a package dependency. If the validation environment doesn't have FFmpeg installed, the portable exe may fail a runtime check.

Any details from the installation log would be very helpful. Thanks!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 21, 2026
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-136-350443-20260323-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. New-Manifest Validation-Installation-Error Error installing application labels Mar 23, 2026
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Mar 23, 2026
@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 23, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b292a77 into microsoft:master Mar 23, 2026
1 check passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants