Skip to content

[Remove version] Taozuhong.KangarooMariaDB 9.1.1.201#354646

Merged
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:masterfrom
taozuhong:Remove-MariaDB
Apr 9, 2026
Merged

[Remove version] Taozuhong.KangarooMariaDB 9.1.1.201#354646
microsoft-github-policy-service[bot] merged 2 commits intomicrosoft:masterfrom
taozuhong:Remove-MariaDB

Conversation

@taozuhong
Copy link
Copy Markdown
Contributor

@taozuhong taozuhong commented Apr 2, 2026

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.12 schema?
Microsoft Reviewers: Open in CodeFlow

@taozuhong
Copy link
Copy Markdown
Contributor Author

@stephengillie Could you give me a hand?

Just want to delete the version and the file added by vscode.

@stephengillie
Copy link
Copy Markdown
Collaborator

Hi @taozuhong,

The issue here is that the .validation file is being removed. This is a "system" file that the validation pipelines add, to record which PackageIdentifiers have which waivers. It can only be removed by moderators.
image

I'm not seeing any file added by VSCode. If the .validation file removal were reverted, the PR should pass this check.

@taozuhong
Copy link
Copy Markdown
Contributor Author

.validation is not needed by all project, so I want to delete it.

@Trenly
Copy link
Copy Markdown
Contributor

Trenly commented Apr 6, 2026

@taozuhong - You will need to remove the .validation file in a separate PR, it cannot be part of the same PR as a manifest.

Additionally, if you remove it, all future submissions for Taozuhong.Kangaroo.MariaDB may be unable to be merged as they will receive Validation-Domain error, which requires the .validation file to indicate that this is an accepted error.

@taozuhong
Copy link
Copy Markdown
Contributor Author

taozuhong commented Apr 8, 2026

@stephengillie @Trenly the .validation only applied with version 9.1.1.201, it should be deleted with this version

{"ValidationVersion":"1.0.0","Waivers":[{"WaiverId":"2afd0909-8889-4dcc-b8e2-b69ea00307d4","TestPlan":"Validation-Domain","PackagePath":"manifests/t/Taozuhong/KangarooMariaDB/9.1.1.201","CommitId":"f16e83c0aa4c7b4dc3012bead0752b84538ae4a9"}],"StandardInstallationVerification":{"Executables":[]}}

@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-138-354646-20260409-1

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 9, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 9, 2026 01:57
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b31c296 into microsoft:master Apr 9, 2026
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 9, 2026
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Trenly
Copy link
Copy Markdown
Contributor

Trenly commented Apr 9, 2026

@stephengillie @Trenly the .validation only applied with version 9.1.1.201, it should be deleted with this version

{"ValidationVersion":"1.0.0","Waivers":[{"WaiverId":"2afd0909-8889-4dcc-b8e2-b69ea00307d4","TestPlan":"Validation-Domain","PackagePath":"manifests/t/Taozuhong/KangarooMariaDB/9.1.1.201","CommitId":"f16e83c0aa4c7b4dc3012bead0752b84538ae4a9"}],"StandardInstallationVerification":{"Executables":[]}}

That's the validation that it was originally applied in. That waiver is why #354304 didn't get the Validation-Domain label.

If the waiver is removed, it will just have to be re-added the next time any version would encounter the Validation-Domain check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants