Skip to content

Swift: adjust package dependencies#354903

Merged
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom
compnerd:dependencies
Apr 13, 2026
Merged

Swift: adjust package dependencies#354903
microsoft-github-policy-service[bot] merged 1 commit intomicrosoft:masterfrom
compnerd:dependencies

Conversation

@compnerd
Copy link
Copy Markdown
Contributor

@compnerd compnerd commented Apr 2, 2026

Make package dependencies architecture specific and shared. Git is shared, but ensure that we depend on the ARM64 runtime redistributable on ARM64 and the X64 on X64. Push the python dependency down into a package dependency that is filtered on architecture as this dependency is also architecture dependent.

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.12 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

Make package dependencies architecture specific and shared. Git is
shared, but ensure that we depend on the ARM64 runtime redistributable
on ARM64 and the X64 on X64. Push the python dependency down into a
package dependency that is filtered on architecture as this dependency
is also architecture dependent.
@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-136-354903-20260402-1

@compnerd
Copy link
Copy Markdown
Contributor Author

compnerd commented Apr 2, 2026

CC: @shahmishal

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 2, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 2, 2026
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

Failure to parse win 10, attempting win 11
Installation failed with exit code -1978334972
Error occurred while trying to capture screenshot. System.ComponentModel.Win32Exception (6): The handle is invalid.
2026-04-02 17:53:52.108 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.arm64 with version 14.50.35719.0
2026-04-02 10:20:35.228 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.50.35719.0
2026-04-02 10:20:35.355 [CLI ] No suitable installer found for manifest Python.Python.3.10 with version 3.10.11

Hex Dec Inverted Dec Symbol Description

(Automated response - build 1240.)

@DandelionSprout
Copy link
Copy Markdown
Contributor

DandelionSprout commented Apr 7, 2026

While Winget's validation already has problems handling InstallerScope differences between an app and its listed dependencies, it's particularly bad when it comes to packages that need InstallerScope: user, as even the silliest hotfixes made to the dependencies themselves wouldn't fix it.

So the best you (Mostly compnerd) can hope for is for the PR to get manually approved by an admin.

@stephengillie
Copy link
Copy Markdown
Collaborator

@wingetbot run

@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-138-354903-20260408-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Apr 8, 2026
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Apr 8, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 8, 2026
@compnerd
Copy link
Copy Markdown
Contributor Author

compnerd commented Apr 8, 2026

The logs don't explain what went wrong, I'm not sure what there is to fix here

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Apr 8, 2026
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978334972
Error occurred while trying to capture screenshot. System.ComponentModel.Win32Exception (6): The handle is invalid.
2026-04-08 17:41:20.267 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.arm64 with version 14.50.35719.0
2026-04-08 10:35:24.402 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.50.35719.0
2026-04-08 10:35:24.611 [CLI ] No suitable installer found for manifest Python.Python.3.10 with version 3.10.11

Hex Dec Inverted Dec Symbol Description
8A150104 -1978334972 2316632324 APPINSTALLER_CLI_ERROR_INSTALL_MISSING_DEPENDENCY This package has a dependency missing from your system. (The most common dependency is Microsoft.VCRedist.2015+.x64 / .x86)

(Automated response - build 1244.)

@compnerd
Copy link
Copy Markdown
Contributor Author

compnerd commented Apr 8, 2026

@stephengillie, ooh, how did you get that? A few users have reported this failure, I'm not sure what the fix is, they are packages in the repository.

@stephengillie
Copy link
Copy Markdown
Collaborator

@wingetbot run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 9, 2026
@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-138-354903-20260409-1

@stephengillie
Copy link
Copy Markdown
Collaborator

Hi @compnerd,

I'm not sure if they're seeing the same error - it's due to a unique setup in our pipelines. Dependencies are preinstalled, to better isolate the main package, for scanning. And so this error is generated by the pipeline software, which isn't available to the public.

This error was extracted from pipeline artifacts and filtered to return only useful error data, then matched against a list of exit codes. I can give more info if you want.

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Apr 10, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Apr 10, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Apr 10, 2026
@stephengillie
Copy link
Copy Markdown
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978334972
2026-04-09 15:29:47.523 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.50.35719.0
2026-04-09 15:29:47.607 [CLI ] No suitable installer found for manifest Python.Python.3.10 with version 3.10.11

Hex Dec Inverted Dec Symbol Description
8A150104 -1978334972 2316632324 APPINSTALLER_CLI_ERROR_INSTALL_MISSING_DEPENDENCY This package has a dependency missing from your system. (The most common dependency is Microsoft.VCRedist.2015+.x64 / .x86)

(Automated response - build 1247.)

@stephengillie
Copy link
Copy Markdown
Collaborator

This PR doesn't change the installer details for x64, but merely rearranges them. The errors are for x64, so I'm assuming the arm64 version passed.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. labels Apr 13, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 13, 2026
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit cd953f6 into microsoft:master Apr 13, 2026
1 check passed
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants