Skip to content

ThioJoe.SvgThumbnailExtension version 1.10.0#364874

Merged
microsoft-github-policy-service[bot] merged 3 commits intomicrosoft:masterfrom
ThioJoe:ThioJoe.SvgThumbnailExtension-1.10.0-f43812c7-4001-4e29-b5f8-45e04e9f7e22
Apr 25, 2026
Merged

ThioJoe.SvgThumbnailExtension version 1.10.0#364874
microsoft-github-policy-service[bot] merged 3 commits intomicrosoft:masterfrom
ThioJoe:ThioJoe.SvgThumbnailExtension-1.10.0-f43812c7-4001-4e29-b5f8-45e04e9f7e22

Conversation

@ThioJoe
Copy link
Copy Markdown
Contributor

@ThioJoe ThioJoe commented Apr 24, 2026

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.12 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-140-364874-20260424-1

@wingetbot
Copy link
Copy Markdown
Collaborator

Inconsistencies detected in package ThioJoe.SvgThumbnailExtension version 1.10.0 based on published version 1.9.0

  • Missing property ReleaseDate

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Apr 24, 2026
Added ReleaseDate to the installer manifest.
@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-140-364874-20260424-2

@microsoft-github-policy-service microsoft-github-policy-service Bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Manifest Validation-No-Executables Manifest-Metadata-Consistency labels Apr 24, 2026
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Apr 24, 2026
Updated installer type from 'wix' to 'msi' and adjusted related fields. Hopefully this fixes the Validation-No-Executables label.
@wingetbot
Copy link
Copy Markdown
Collaborator

Validation Pipeline Run WinGetSvc-Validation-140-364874-20260424-3

@microsoft-github-policy-service microsoft-github-policy-service Bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Manifest Validation-No-Executables labels Apr 24, 2026
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Apr 24, 2026
@ThioJoe
Copy link
Copy Markdown
Contributor Author

ThioJoe commented Apr 25, 2026

Ok I'm stumped about the "Validation-No-Executables" label 🤔

I did notice during testing that even though it's signed, smart screen would apparently fail to run it if the mark of the web was applied, and it would just not run the installer after downloading and verifying its hash.

The verbose log would just end with:

2026-04-23 12:13:09.292 [CLI ] Installer hash verified
2026-04-23 12:13:09.292 [CORE] Started applying motw using IAttachmentExecute to C:\Users\Joe\AppData\Local\Temp\WinGet\ThioJoe.SvgThumbnailExtension.1.10.0\dbef9a205640ac7076fe732db8db0e294b80fcaca45faa81db2d0c81ddaac71c

But after manually removing mark of the web it worked. Not sure if it's the same cause of the label.

Seems to be same thing as inkstitch/inkstitch#4287

@stephengillie stephengillie added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 25, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot merged commit 66e1f10 into microsoft:master Apr 25, 2026
1 check passed
@wingetbot
Copy link
Copy Markdown
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants