Skip to content

AMD.OCAT 1.6.0#4019

Closed
meashishsaini wants to merge 1 commit intomicrosoft:masterfrom
meashishsaini:ocat
Closed

AMD.OCAT 1.6.0#4019
meashishsaini wants to merge 1 commit intomicrosoft:masterfrom
meashishsaini:ocat

Conversation

@meashishsaini
Copy link
Copy Markdown

@meashishsaini meashishsaini commented Oct 8, 2020 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?
Microsoft Reviewers: Open in CodeFlow

@meashishsaini
AMD.OCAT 1.6.0
4c32aca 
Signed-off-by: Ashish Saini <sainiashish08@gmail.com>
@wingetbot
Copy link
Copy Markdown
Collaborator

wingetbot commented Oct 8, 2020

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 8, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Oct 8, 2020
@ghost ghost assigned KevinLaMS Oct 8, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 8, 2020

This submission has moved to manual review.

@ghost
Copy link
Copy Markdown

ghost commented Oct 8, 2020

Greetings. This package fails because it is dependent on the Visual Studio Runtime and we do not support the dependencies yet. See issue: microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

@ghost ghost added Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Oct 8, 2020
@ghost ghost assigned meashishsaini Oct 8, 2020
@KevinLaMS
Copy link
Copy Markdown
Contributor

KevinLaMS commented Oct 8, 2020 •
edited
Loading

running app pops vcruntime dependency error

image

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Oct 8, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 8, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@KevinLaMS KevinLaMS removed the Validation-Completed Validation passed label Oct 8, 2020
@meashishsaini
Copy link
Copy Markdown
Author

meashishsaini commented Oct 8, 2020

It does install 64-bit version of vc-runtime. I guess it also requires 32-bit version of vc-runtime installed. Sorry about that.
This app needs to wait until dependencies are supported then.

@ghost ghost mentioned this pull request Jul 29, 2021
Merged
@ghost ghost closed this in #22759 Jul 29, 2021
@RokeJulianLockhart RokeJulianLockhart mentioned this pull request Jul 5, 2025
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KevinLaMS KevinLaMS

@meashishsaini meashishsaini

Labels

Blocking-Issue Manifest validation is blocked by a known issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meashishsaini @wingetbot @KevinLaMS