Skip to content

Add GoldWave 6.52#4147

Merged
2 commits merged intomicrosoft:masterfrom
chausner:goldwave652
Oct 15, 2020
Merged

Add GoldWave 6.52#4147
2 commits merged intomicrosoft:masterfrom
chausner:goldwave652

Conversation

@chausner
Copy link
Copy Markdown
Contributor

@chausner chausner commented Oct 12, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Oct 12, 2020
@ghost ghost assigned KevinLaMS Oct 12, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 12, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Error General Error during testing. Requires we provide comment to author. label Oct 14, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2020

chausner An issue was identified during the manual review, and the PR request cannot be approved. Please see comments for more information.
Please address the issue and resubmit, or if you disagree with this resolution, please raise an issue and flag this PR for further discussion.

@ghost ghost assigned chausner Oct 14, 2020
@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Oct 14, 2020
@KevinLaMS
Copy link
Copy Markdown
Contributor

KevinLaMS commented Oct 14, 2020

i seem to be getting a 403 error

image

tweaked image

@ghost ghost added Needs: Attention and removed Needs: author feedback Validation-Error General Error during testing. Requires we provide comment to author. labels Oct 14, 2020
@wingetbot
Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@chausner
Copy link
Copy Markdown
Contributor Author

i seem to be getting a 403 error

Should be fixed now. The download URL changed.

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Oct 14, 2020
@ghost ghost assigned denelon Oct 14, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 14, 2020

This submission has moved to manual review.

@ghost ghost removed the Needs: Attention label Oct 14, 2020
@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Oct 15, 2020
@ghost
Copy link
Copy Markdown

ghost commented Oct 15, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit ae4245f into microsoft:master Oct 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants