Skip to content

New version: FreeCiv.FreeCiv version 3.0.0#47679

Merged
3 commits merged intomicrosoft:masterfrom
OfficialEsco:FreeCiv.FreeCiv-3.0.0-A9552B7273195A
Feb 23, 2022
Merged

New version: FreeCiv.FreeCiv version 3.0.0#47679
3 commits merged intomicrosoft:masterfrom
OfficialEsco:FreeCiv.FreeCiv-3.0.0-A9552B7273195A

Conversation

@OfficialEsco
Copy link
Contributor

@OfficialEsco OfficialEsco commented Feb 22, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 22, 2022
@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Feb 22, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 22, 2022
@OfficialEsco
Copy link
Contributor Author

Btw @ItzLevvie we have access to new logs via the Azure pipelines
https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=276974&view=results
Published/Artifacts -> InstallationVerificationLogs are probably the most interesting

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 22, 2022
@ghost ghost assigned florelis and msftrubengu Feb 22, 2022
@florelis
Copy link
Member

@wingetbot waivers Add Validation-Unapproved-URL

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Validation-Unapproved-URL Needs-Attention This work item needs to be reviewed by a member of the core team. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Feb 22, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@florelis
Copy link
Member

@OfficialEsco do you have a reason to use the mirror from sourceforge and not the one from freeciv.org? This doesn't really matter; just curiosity.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Feb 23, 2022

Hello @OfficialEsco,
Validation has completed.

@ghost ghost merged commit 4277654 into microsoft:master Feb 23, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@OfficialEsco
Copy link
Contributor Author

Its the URL which was used in the first PR #1162
From a little snooping i believe its because the website is HTTP instead of HTTPS

Note for later https://github.com/freeciv/freeciv

@OfficialEsco OfficialEsco deleted the FreeCiv.FreeCiv-3.0.0-A9552B7273195A branch February 23, 2022 06:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed Waived-Validation-Unapproved-URL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants