Skip to content

[Cleanup] analyzer_version field is stale dead metadata #589

@timenick

Description

@timenick

Context

AnalysisOutput.analyzer_version is a string field embedded in the JSON
output of winml analyze. It exists for schema/provenance — letting
downstream tools (diff utilities, CI baselines, archived reports) know
which analyzer version produced a given JSON.

Problem

The field is stale dead metadata:

Result: every analysis output JSON has "analyzer_version": "0.1.0"
regardless of actual analyzer code state. The field carries zero information.

Fix: remove the field

  • src/winml/modelkit/analyze/models/output.py — drop analyzer_version field from AnalysisOutput
  • src/winml/modelkit/analyze/core/output_aggregator.py — drop analyzer_version param from OutputAggregator.__init__ and from the AnalysisOutput(...) construction
  • Update tests that pass or assert analyzer_version:
    • tests/unit/analyze/core/test_output_aggregator.py (~8 occurrences)
    • tests/unit/analyze/models/test_output.py (~9 occurrences)
    • tests/unit/analyze/test_analyzer.py (~6 occurrences)
    • tests/unit/analyze/test_analyze_onnx.py (1)
    • tests/unit/analyze/test_static_analyzer_cli.py (3)
  • Update mock data: tests/mock_data/analyze/output.json

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions