Skip to content

Change support_weight, support_activation to qdq_types in QDQParameterConfig#17

Merged
xieofxie merged 2 commits into
mainfrom
hualxie/update_qdq_support_logic
Mar 30, 2026
Merged

Change support_weight, support_activation to qdq_types in QDQParameterConfig#17
xieofxie merged 2 commits into
mainfrom
hualxie/update_qdq_support_logic

Conversation

@xieofxie
Copy link
Copy Markdown
Contributor

Summary

  • Replaces the separate weight_type and activation_type fields in QDQParameterConfig with a unified qdq_types: list[SupportedONNXType] parameter
  • Converts support_weight and support_activation from computed properties back to plain attributes
  • Updates the assertion to also allow qdq_types as a valid way to configure a parameter
  • Updates all call sites in conv_input_generator.py, matmul_input_generator.py, normalization_input_generator.py, and related tests

Test plan

  • Existing unit tests in tests/unit/analyze/core/test_qdq.py updated to reflect new API
  • Verify CI passes

🤖 Generated with Claude Code

@xieofxie xieofxie requested a review from a team as a code owner March 30, 2026 06:04
@xieofxie xieofxie merged commit 247698e into main Mar 30, 2026
9 checks passed
@xieofxie xieofxie deleted the hualxie/update_qdq_support_logic branch March 30, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants