refactor: move remaining network-dependent tests to integration#254
Merged
Conversation
Move tests that call HuggingFace Hub APIs out of tests/unit/: - test_text_classification.py → tests/integration/datasets/ (every test downloads GLUE/MRPC via load_dataset) - TestResolveTaskAndModelClass and TestConflictScenarios from test_hf_model_class_mapping.py → tests/integration/loader/ (13 tests call AutoConfig.from_pretrained, missed in #95) Fixes #253
chinazhangchao
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_text_classification.pyfromtests/unit/eval/totests/integration/datasets/— every test downloads GLUE/MRPC viaload_datasetTestResolveTaskAndModelClassandTestConflictScenarios(13 tests usingAutoConfig.from_pretrained()) fromtests/unit/loader/test_hf_model_class_mapping.pytotests/integration/loader/test_hf_model_class_mapping.py— these were missed in Move misplaced integration/e2e tests out of tests/unit/ #95Fixes #253