fix: make --device flag case-insensitive consistent with other commands (#215)#264
Merged
Merged
Conversation
…ds (#215) winml analyze --device only accepted uppercase (CPU/GPU/NPU) while all other commands (compile, eval, perf, config) accept lowercase. Change click.Choice to case_sensitive=False so npu/gpu/cpu are accepted. Click normalizes the value to uppercase, so no downstream code changes are needed.
timenick
approved these changes
Apr 8, 2026
chinazhangchao
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winml analyze --deviceonly accepted uppercase (NPU,GPU,CPU). All other commands (compile,eval,perf,config) accept lowercase. This single-character fix makes thedevice_option()helper consistent.Change
src/winml/modelkit/utils/cli.py:81—case_sensitive=True→case_sensitive=Falseclick.Choicewithcase_sensitive=Falsenormalizes the user input to match the canonical form in the choices list ("npu"→"NPU"), so no downstream code changes are needed.Before / After
Before — lowercase input fails:
After — any casing accepted, value normalized to uppercase:
Closes #215