fix: delete stale external data sidecar before save_onnx overwrites it#320
Merged
Conversation
…rites it ORT quantize() writes the .data sidecar, then save_onnx tries to write the same file again and hits onnx's FileExistsError. Delete the sidecar before saving so the overwrite succeeds cleanly.
xieofxie
changed the title
Contributor
Author
|
Found when trying quantize |
fangyangci
approved these changes
Apr 13, 2026
DingmaomaoBJTU
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quantize_onnxcalls ORT'squantize()(Step 3) which writes<output>.onnx.data, then callssave_onnx(Step 8) which tries to write the same sidecar againonnx.save_modelhas no overwrite option and raisesFileExistsError: External data file exists in <location>save_onnxnow deletes the existing.datasidecar before writing, so re-saving over an ORT-generated file works cleanly