feat: show tqdm for _ensure_provider_ready by xieofxie · Pull Request #788 · microsoft/winml-cli

xieofxie · 2026-05-29T04:09:17Z

Closes #725

winml sys <

Failed

DingmaomaoBJTU

Nice implementation. The async flow with threading.Event is clean, the timeout is configurable via env var, and tests are thorough. Two minor observations below.

xieofxie · 2026-06-04T02:42:24Z

+    # this branch only runs on the cold "EP needs download" path.
+    from ..utils.console import get_console
+
+    console = get_console()


Add a new issue to suppress this #811

feat: show tqdm for _ensure_provider_ready

d20ad87

xieofxie requested a review from a team as a code owner May 29, 2026 04:09

hualxie added 2 commits May 29, 2026 14:56

add timeout

80329ba

change to info

d7995aa

This comment was marked as duplicate.

Sign in to view

Merge remote-tracking branch 'origin/main' into hualxie/ep_downloading

4fd0a28

xieofxie commented Jun 1, 2026

View reviewed changes

Comment thread src/winml/modelkit/session/ep_registry.py Outdated

This comment was marked as duplicate.

Sign in to view

xieofxie commented Jun 1, 2026

View reviewed changes

Comment thread src/winml/modelkit/session/ep_registry.py Outdated

xieofxie commented Jun 1, 2026

View reviewed changes

Comment thread src/winml/modelkit/session/ep_registry.py

hualxie added 2 commits June 1, 2026 15:59

fix comments

013bddd

tqdm optional

e12c40e

xieofxie commented Jun 1, 2026

View reviewed changes

Comment thread src/winml/modelkit/session/ep_registry.py

This comment was marked as duplicate.

Sign in to view

DingmaomaoBJTU reviewed Jun 1, 2026

View reviewed changes

Comment thread src/winml/modelkit/session/ep_registry.py

Comment thread src/winml/modelkit/session/ep_registry.py

xieofxie added 5 commits June 2, 2026 10:52

Merge remote-tracking branch 'origin/main' into hualxie/ep_downloading

fcff3dc

bug fix

0be0942

add OSError

7dc8a2c

Merge remote-tracking branch 'origin/main' into hualxie/ep_downloading

a44c578

update output

cdd4a4f

github-advanced-security AI found potential problems Jun 3, 2026

View reviewed changes

Comment thread tests/unit/session/test_ep_registry.py Fixed

xieofxie commented Jun 3, 2026

View reviewed changes

Comment thread src/winml/modelkit/session/ep_registry.py Outdated

hualxie and others added 4 commits June 3, 2026 16:45

ready_state has bug

fd0c63c

remove .

06f37dd

Merge remote-tracking branch 'origin/main' into hualxie/ep_downloading

c2ae53b

apply updates

c5cb0c4

xieofxie commented Jun 4, 2026

View reviewed changes

Conversation

xieofxie commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

DingmaomaoBJTU left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xieofxie Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xieofxie commented May 29, 2026 •

edited

Loading